Skip to content

fix(hvf): preserve nested context and timers across restore - #162

Open
toksdotdev wants to merge 2 commits into
toks/windows-nested-snapshot-statefrom
toks/macos-nested-snapshot-state
Open

toksdotdev wants to merge 2 commits into
toks/windows-nested-snapshot-statefrom
toks/macos-nested-snapshot-state

Conversation

@toksdotdev

@toksdotdev toksdotdev commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

correct the EL2 register binding and capture the implemented register inventory. restore the clock before timers, initialize a fresh EL2 context, and rearm timer notifications so a restored inner vm resumes rather than stalling. includes native macos capture/restore regression tooling; qualification is for supported apple silicon hosts.

merge order: #156 → #155 → #158 → #159 → #160 → #162 → #169 → #168. linux arm64 groundwork remains separately in draft #164 and is not required for this release.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no actionable new issue was found.

Reviews (14) · Last reviewed commit: "chore(stack): inherit nested restore CI ..." · Reviewed by Greptile

Comment thread tests/nested-restore-hvf/macos.rs
Comment thread tests/nested-restore-hvf/README.md
Comment thread tests/nested-restore/main.rs Outdated
@toksdotdev
toksdotdev added this pull request to stack #161 October 14, 2026 13:26
@toksdotdev
toksdotdev force-pushed the toks/macos-nested-snapshot-state branch from d69a2cb to 4eb6f8b Compare October 14, 2026 21:15
@toksdotdev
toksdotdev removed this pull request from stack #161 October 14, 2026 21:16
@toksdotdev toksdotdev changed the title test(hvf): qualify native nested snapshot capture fix(hvf): preserve nested context and timers across restore Oct 14, 2026
@toksdotdev
toksdotdev marked this pull request as ready for review October 14, 2026 21:16
@toksdotdev
toksdotdev added this pull request to stack #170 October 14, 2026 21:17
@toksdotdev
toksdotdev force-pushed the toks/macos-nested-snapshot-state branch from 4eb6f8b to 704f944 Compare October 14, 2026 23:05
@toksdotdev
toksdotdev force-pushed the toks/macos-nested-snapshot-state branch 2 times, most recently from 1d08ce7 to 494d212 Compare October 15, 2026 16:01
Retain corrected EL2 bindings, implemented register inventory, clock-first restore, fresh EL2 initialization, and timer notification rearming with the native qualification harness. Restack the reviewed macOS backend without the unqualified Linux ARM implementation.
@toksdotdev
toksdotdev force-pushed the toks/macos-nested-snapshot-state branch from 494d212 to fa95bc1 Compare October 15, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant