chore(deps): update dependency @patternfly/react-icons to v6.6.1 - #189
chore(deps): update dependency @patternfly/react-icons to v6.6.1#189red-hat-konflux[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Amber reviewStatus: Complete VerdictCOMMENT — no blockers. This is a low-risk, single-line Renovate/MintMaker bump of Amber Analysis A dependency-only change with no Go/security/reconciler surface, so the HyperShell backend conventions (panic-free, error wrapping, SecurityContext, reconcile pattern, secret handling) are N/A here. The change is safe to ship; my one substantive note is a consistency gap that Renovate would normally have handled by moving both the peer and dev entries together. Findings[Minor]
Cross-PR coordinationI reviewed all other open PRs in
Bottom line: no material cross-PR conflict; the only actionable coordination is aligning the PatternFly 6.6.1 bumps (#188/#189) so dev/peer/lock and sibling packages stay in lockstep. Other open PRs reviewed for conflicts#73, #75, #109, #135, #148, #150, #151, #179, #182, #185, #188, #194, #200, #201, #206, #207, #208, #209, #210, #211, #212, #214, #216. Findings Summary (ordered by severity, highest first)
Convention Checklist
|
jsell-rh
left a comment
There was a problem hiding this comment.
Verdict
COMMENT — no blockers. This is a low-risk, single-line Renovate/MintMaker bump of @patternfly/react-icons from 6.6.0 to 6.6.1 in the reusable gateway-management-ui package. The only issue is an intra-file version drift: the peerDependencies entry was bumped but the matching devDependencies entry (and the lockfile resolution) stayed at 6.6.0, so the package is not actually built/tested against the version it now declares it needs.
Amber Analysis
A dependency-only change with no Go/security/reconciler surface, so the HyperShell backend conventions (panic-free, error wrapping, SecurityContext, reconcile pattern, secret handling) are N/A here. The change is safe to ship; my one substantive note is a consistency gap that Renovate would normally have handled by moving both the peer and dev entries together.
Findings
[Minor] peerDependencies and devDependencies for @patternfly/react-icons now disagree — Dependency consistency (packages/gateway-management-ui/package.json L25 vs L37)
peerDependencies["@patternfly/react-icons"]is bumped to6.6.1(L25), butdevDependencies["@patternfly/react-icons"]remains6.6.0(L37), andpnpm-lock.yamlstill resolves react-icons to6.6.0(importer specifier6.6.0, resolution@patternfly/react-icons@6.6.0).- Effect: this package declares that consumers must supply
6.6.1, yet it is compiled/type-checked/tested against6.6.0. That is the exact version it is asking downstream (web-console) to install, so it is validated against a different version than it advertises. - No CI break is expected from this alone: pnpm's lockfile tracks only
dependencies/devDependenciesspecifiers, notpeerDependencies, so--frozen-lockfileshould still pass. But the drift is real and defeats the point of the bump. - Fix: bump
devDependencies["@patternfly/react-icons"]to6.6.1as well and regeneratepnpm-lock.yamlin the same PR, so dev/peer/lock all agree. Confidence: High.
Cross-PR coordination
I reviewed all other open PRs in openshift-online/hypershell (see list below). No material logical/structural/plan conflict with #189 was found — no duplicate solution, incompatible design, competing interface, or required change-ordering. There is one worth-noting coordination point:
- #188
chore(deps): update dependency @patternfly/react-core to v6.6.1touches the samepeerDependenciesblock in the same file (packages/gateway-management-ui/package.json) and uses the identical partial-update pattern: it bumps only the peer entry to6.6.1and leaves thedevDependenciesentry at6.6.0. This is complementary, not competing — the two PRs move different PatternFly sub-packages. The coordination question for maintainers is ecosystem lockstep: PatternFlyreact-core/react-icons/react-tableare expected to share a version, so after both merge you would havereact-core@6.6.1+react-icons@6.6.1butreact-tablestill6.6.0, plus dev/peer drift in both. Suggest batching the PatternFly 6.6.1 bumps (and bumpingreact-table+ the dev entries + lockfile together) rather than landing them piecemeal. This is a coordination preference, not a blocking design decision. - #135
chore(deps): update dependency react-intl to v10.1.20also edits the same file but a different (react-intl) line. Only a trivial textual rebase overlap — not a material conflict. - Other PRs that touch
packages/gateway-management-ui/(#208, #210, #211, #209, #214) modify source files undersrc/, notpackage.json, so they do not interact with this dependency pin.
Bottom line: no material cross-PR conflict; the only actionable coordination is aligning the PatternFly 6.6.1 bumps (#188/#189) so dev/peer/lock and sibling packages stay in lockstep.
Other open PRs reviewed for conflicts
#73, #75, #109, #135, #148, #150, #151, #179, #182, #185, #188, #194, #200, #201, #206, #207, #208, #209, #210, #211, #212, #214, #216.
Findings Summary (ordered by severity, highest first)
- [Minor]
peerDependenciesreact-icons bumped to6.6.1whiledevDependencies+ lockfile stay at6.6.0— Dependency consistency (L25, L37)
Convention Checklist
| Convention | Result |
|---|---|
| Image references consistent across the stack | Pass |
| Dependency pin consistent within file (peer vs dev vs lock) | Fail |
| Conventional commit message | Pass |
| "peerDependencies": { | ||
| "@patternfly/react-core": "6.6.0", | ||
| "@patternfly/react-icons": "6.6.0", | ||
| "@patternfly/react-icons": "6.6.1", |
There was a problem hiding this comment.
This bumps the peer dependency to 6.6.1, but the devDependencies entry for @patternfly/react-icons (line 37, unchanged) is still 6.6.0, and pnpm-lock.yaml resolves it to 6.6.0. The package therefore declares consumers must supply 6.6.1 while it is itself built and tested against 6.6.0. Bump the dev entry to 6.6.1 and regenerate the lockfile in this PR so peer/dev/lock all agree. (No --frozen-lockfile break expected, since pnpm does not track peerDependencies specifiers in the lockfile.)
This PR contains the following updates:
6.6.0→6.6.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
patternfly/patternfly-react (@patternfly/react-icons)
v6.6.1Compare Source
Configuration
📅 Schedule: (in timezone America/New_York)
* 0-7 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.