chore(deps): update dependency @patternfly/react-core to v6.6.1 - #188
chore(deps): update dependency @patternfly/react-core to v6.6.1#188red-hat-konflux[bot] wants to merge 1 commit into
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Amber reviewStatus: Complete VerdictCOMMENT (recommend changes before merge). This is a low-risk Renovate patch bump of Hi, Amber here. I reviewed the single-line dependency change against the HyperShell conventions (notably "image/dependency references must match across the stack") and cross-checked the other open PRs for coordination issues. SummaryThe change itself is a valid conventional-commit patch bump and carries little functional risk for a PatternFly patch release. My concern is consistency: Findings[Major] Intra-package version split for [Major] Consumer [Minor] Sibling PatternFly packages left out of lockstep — [Info] Lockfile unchanged — Cross-PR coordinationI compared this PR against the other open PRs in
No material cross-PR conflict beyond the #189 lockstep coordination above. Recommended actionUpdate Findings Summary (ordered by severity, highest first):
Convention Checklist:
|
jsell-rh
left a comment
There was a problem hiding this comment.
Verdict
COMMENT (recommend changes before merge). This is a low-risk Renovate patch bump of @patternfly/react-core 6.6.0 -> 6.6.1, but it only updates the peerDependencies entry and leaves the package's own devDependency and the consuming web-console at 6.6.0, creating a PatternFly version split across the stack that should be resolved before merge.
Hi, Amber here. I reviewed the single-line dependency change against the HyperShell conventions (notably "image/dependency references must match across the stack") and cross-checked the other open PRs for coordination issues.
Summary
The change itself is a valid conventional-commit patch bump and carries little functional risk for a PatternFly patch release. My concern is consistency: @patternfly/react-core is now declared at two different versions inside the same package.json, its sibling PatternFly packages stay at 6.6.0, and the only consumer (web-console) still provides 6.6.0, so the newly-declared peer requirement is not actually satisfied anywhere in the workspace.
Findings
[Major] Intra-package version split for @patternfly/react-core — peerDependencies was bumped to 6.6.1 (line 24) but devDependencies still pins 6.6.0 (line 36). The package is therefore built and tested against 6.6.0 while declaring it needs 6.6.1 from consumers. These two entries should move together. Convention: dependency references must match across the stack. Confidence: High.
[Major] Consumer web-console still provides 6.6.0 -> unmet peer — components/web-console/package.json:34 pins @patternfly/react-core: 6.6.0. Because the peer requirement here is an exact pin (6.6.1), the sole workspace consumer no longer satisfies it, which will surface as an unmet-peer warning/resolution mismatch. Either bump the consumer too or land this with the coordinated set (see Cross-PR section). Confidence: Medium-High.
[Minor] Sibling PatternFly packages left out of lockstep — @patternfly/react-icons and @patternfly/react-table remain 6.6.0 in both peerDependencies and devDependencies. PatternFly expects @patternfly/* to be installed at matching versions; mixing 6.6.1 core with 6.6.0 icons/table is usually fine within a patch line but is best kept in lockstep. Confidence: Medium.
[Info] Lockfile unchanged — pnpm-lock.yaml still records 6.6.0. pnpm does not enumerate peerDependencies in importer snapshots, so a frozen-lockfile install is unlikely to break from this change alone; I mention it only so a maintainer can confirm CI stays green. Confidence: Low.
Cross-PR coordination
I compared this PR against the other open PRs in openshift-online/hypershell. Open PRs at review time: #216, #214, #212, #211, #210, #209, #208, #207, #206, #201, #200, #194, #189, #188 (this PR), #185, #182, #179, #151, #150, #148, #135, #109, #75, #73.
- #189
chore(deps): update dependency @patternfly/react-icons to v6.6.1— material coordination. #189 is a sibling PatternFly bump that edits the same file and the samepeerDependenciesblock (packages/gateway-management-ui/package.json), moving@patternfly/react-icons6.6.0 -> 6.6.1. Together, #188 + #189 (plus areact-tablebump) constitute one lockstep PatternFly6.6.1upgrade. Landing #188 alone leaves the PatternFly family mismatched (core6.6.1, icons/table6.6.0), and neither PR touches thedevDependenciesor theweb-consoleconsumer. Maintainer decision needed: land these PatternFly bumps as a coordinated set (and includereact-table, thedevDependency, and theweb-consolepin) rather than piecemeal. This is a plan/ordering coordination, not merely the text merge conflict that will also occur on second merge. - #135
chore(deps): update dependency react-intl to v10.1.20— no material conflict. It edits the samepackage.jsonpeerDependenciesblock but a different, unrelated package (react-intl). The only overlap is a routine text merge on the second merge; there is no design, data-model, interface, or ordering conflict. - UI/web-console PRs (#216, #214, #210, #209, #208, #207) — no material conflict. These add/modify UI features that consume PatternFly but do not change its version. A PatternFly patch bump is not expected to alter public component APIs, so there is no incompatible design or competing interface change.
- All other open PRs (control-plane, auth, e2e, images, docs, Go/container dependency bumps) touch unrelated areas with no goal, ownership, data-model, or ordering conflict with this frontend dependency bump.
No material cross-PR conflict beyond the #189 lockstep coordination above.
Recommended action
Update devDependencies @patternfly/react-core to 6.6.1 in this same file, and coordinate with #189 (and a react-table bump + the web-console consumer pin) so the entire PatternFly family lands at 6.6.1 together. Rollback is trivial: revert this one-line change.
Findings Summary (ordered by severity, highest first):
- [Major]
@patternfly/react-coresplit acrosspeerDependencies(6.6.1) anddevDependencies(6.6.0) - Dependency Consistency (L24, L36) - [Major] Consumer
web-consolestill pins 6.6.0, leaving the new exact peer requirement unsatisfied - Dependency Consistency (components/web-console/package.json:34) - [Minor] Sibling
@patternfly/react-icons/@patternfly/react-tableleft at 6.6.0, breaking PatternFly lockstep - Dependency Consistency (L25-26) - [Info]
pnpm-lock.yamlunchanged; confirm frozen-lockfile CI stays green - Build Hygiene
Convention Checklist:
| Convention | Result |
|---|---|
| Conventional commit message | Pass |
| Dependency references match across the stack | Fail |
| Config separate from code | Pass |
| No secrets in logs/responses | N/A (no code change) |
| }, | ||
| "peerDependencies": { | ||
| "@patternfly/react-core": "6.6.0", | ||
| "@patternfly/react-core": "6.6.1", |
There was a problem hiding this comment.
[Major] Version split within this file. This peerDependencies entry is now @patternfly/react-core: 6.6.1, but the devDependencies entry (line 36) still pins 6.6.0, so the package is built/tested against 6.6.0 while declaring it needs 6.6.1 from consumers. Bump the devDependency in the same change so both match. Also note the sole consumer components/web-console/package.json:34 still provides 6.6.0, which no longer satisfies this exact peer pin. Consider landing together with #189 (react-icons 6.6.1) and a react-table bump to keep the PatternFly family in lockstep.
This PR contains the following updates:
6.6.0→6.6.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
patternfly/patternfly-react (@patternfly/react-core)
v6.6.1Compare Source
Configuration
📅 Schedule: (in timezone America/New_York)
* 0-7 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.