Skip to content

chore(deps): update dependency react-intl to v10.1.20 - #135

Closed
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/formatjs-monorepo
Closed

chore(deps): update dependency react-intl to v10.1.20#135
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/formatjs-monorepo

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
react-intl (source) 10.1.18 → 10.1.20 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.

Release Notes

formatjs/formatjs (react-intl)

v10.1.20: react-intl: 10.1.20

Compare Source

10.1.20 (2026-08-02)

What's Changed

Full Changelog: https://github.com/formatjs/formatjs/compare/react-intl@10.1.19...react-intl@10.1.20

v10.1.19: react-intl: 10.1.19

Compare Source

10.1.19 (2026-07-30)

What's Changed

New Contributors

Full Changelog: https://github.com/formatjs/formatjs/compare/react-intl@10.1.18...react-intl@10.1.19

Dependencies

Configuration

📅 Schedule: (in timezone America/New_York)

  • Branch creation
    • Between 12:00 AM and 07:59 AM, only on Monday (* 0-7 * * 1)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.

Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux

red-hat-konflux Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
[ERR_PNPM_UNSUPPORTED_ENGINE] Unsupported environment (bad pnpm and/or Node.js version)

Your Node version is incompatible with "/tmp/renovate/repos/github/openshift-online/hypershell".

Expected version: >=24.18.1
Got: v24.11.0

This is happening because the package's manifest has an engines.node field specified.
To fix this issue, install the required Node version.

@red-hat-konflux
chore(deps): update dependency react-intl to v10.1.20
3c1da77 
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/formatjs-monorepo branch from 77378b6 to 3c1da77 Compare August 24, 2026 05:13
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5f576f10-f528-41a8-beac-94daf5295367

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@jsell-rh

jsell-rh commented Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Amber review

Status: Complete

Verdict

COMMENT - The single-line react-intl bump is safe in isolation, but it is an incomplete dependency change: only the peerDependencies entry moves to 10.1.20 while the matching devDependencies entry, the web-console consumer, and pnpm-lock.yaml all remain pinned to 10.1.18. As written the package is still built and tested against 10.1.18 and now declares an exact peer that none of its providers satisfy, so I recommend reconciling the version across the workspace before merge.

Hi team - Amber here. This is a Konflux/Renovate bump of react-intl (10.1.18 -> 10.1.20) in packages/gateway-management-ui/package.json. No Go, control-plane, or security-context surface is touched, so the HyperShell backend/security conventions are largely N/A. The substance is dependency hygiene and cross-package version consistency.

Findings

[Major] Version bump is incoherent across the workspace - Version Consistency (packages/gateway-management-ui/package.json:31, :57)

The diff bumps only the peerDependencies block:

  • packages/gateway-management-ui/package.json:31 (peerDependencies) -> react-intl: 10.1.20 (changed)
  • packages/gateway-management-ui/package.json:57 (devDependencies) -> react-intl: 10.1.18 (unchanged)
  • components/web-console/package.json:43 (the actual consumer that links this package) -> react-intl: 10.1.18 (unchanged)
  • pnpm-lock.yaml -> resolves react-intl@10.1.18 in every importer (unchanged; the PR touches no lockfile)

Because every version in this repo is exact-pinned (no ^/~), the practical effects are:

  1. The upgrade is effectively a no-op for what actually runs/tests. The package's own build and vitest run against the devDependencies version, which is still 10.1.18. Nothing in the tree installs 10.1.20.
  2. The new peer is unsatisfied by every provider. gateway-management-ui now demands exactly 10.1.20 from consumers, but its own devDependency and the web-console consumer both provide 10.1.18, producing an unmet-peer mismatch.

This mirrors the CLAUDE.md convention that references must match across the stack (the same spirit as "image references must match across manifests"). Renovate normally updates all occurrences plus the lockfile; here it caught only one of them.

Recommended fix: bump react-intl to 10.1.20 in all three package.json locations (gateway-management-ui peer + dev, and components/web-console/package.json, plus the new dashboard package noted below if that lands), then regenerate pnpm-lock.yaml (pnpm install) so CI's pnpm install --frozen-lockfile installs and tests the version actually being required.

Confidence: High on the inconsistency itself (the four pins above are verifiable in-tree). Medium on downstream install behavior - in pnpm v9 lockfiles, workspace peerDependencies specifiers are not stored in the importer section, so --frozen-lockfile most likely does not fail on this change, which is precisely why the bump silently has no effect rather than erroring loudly.

Cross-PR coordination

I compared #135 against the other open PRs in openshift-online/hypershell. Open PRs at review time: #216, #214, #212, #211, #210, #209, #208, #207, #206, #201, #200, #194, #189, #188, #185, #182, #179, #151, #150, #148, #135, #109, #75, #73.

Material coordination items:

No other open PR presents a competing design, duplicate solution, or incompatible interface with #135.

Findings Summary (ordered by severity, highest first)

  1. [Major] react-intl bumped only in peerDependencies; devDependencies, the web-console consumer, and pnpm-lock.yaml remain at 10.1.18, so the upgrade neither takes effect nor is satisfied by its providers - Version Consistency (packages/gateway-management-ui/package.json:31, :57)

Convention Checklist

Convention Result
Image/dependency references match across the stack Fail
Conventional commit message (chore(deps): ...) Pass
Configuration separated from code Pass

This was referenced Aug 27, 2026
Open
Open
Closed
Open
Open
Open
Open
jsell-rh
jsell-rh reviewed Aug 27, 2026
View reviewed changes

@jsell-rh jsell-rh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

COMMENT - The single-line react-intl bump is safe in isolation, but it is an incomplete dependency change: only the peerDependencies entry moves to 10.1.20 while the matching devDependencies entry, the web-console consumer, and pnpm-lock.yaml all remain pinned to 10.1.18. As written the package is still built and tested against 10.1.18 and now declares an exact peer that none of its providers satisfy, so I recommend reconciling the version across the workspace before merge.

Hi team - Amber here. This is a Konflux/Renovate bump of react-intl (10.1.18 -> 10.1.20) in packages/gateway-management-ui/package.json. No Go, control-plane, or security-context surface is touched, so the HyperShell backend/security conventions are largely N/A. The substance is dependency hygiene and cross-package version consistency.

Findings

[Major] Version bump is incoherent across the workspace - Version Consistency (packages/gateway-management-ui/package.json:31, :57)

The diff bumps only the peerDependencies block:

  • packages/gateway-management-ui/package.json:31 (peerDependencies) -> react-intl: 10.1.20 (changed)
  • packages/gateway-management-ui/package.json:57 (devDependencies) -> react-intl: 10.1.18 (unchanged)
  • components/web-console/package.json:43 (the actual consumer that links this package) -> react-intl: 10.1.18 (unchanged)
  • pnpm-lock.yaml -> resolves react-intl@10.1.18 in every importer (unchanged; the PR touches no lockfile)

Because every version in this repo is exact-pinned (no ^/~), the practical effects are:

  1. The upgrade is effectively a no-op for what actually runs/tests. The package's own build and vitest run against the devDependencies version, which is still 10.1.18. Nothing in the tree installs 10.1.20.
  2. The new peer is unsatisfied by every provider. gateway-management-ui now demands exactly 10.1.20 from consumers, but its own devDependency and the web-console consumer both provide 10.1.18, producing an unmet-peer mismatch.

This mirrors the CLAUDE.md convention that references must match across the stack (the same spirit as "image references must match across manifests"). Renovate normally updates all occurrences plus the lockfile; here it caught only one of them.

Recommended fix: bump react-intl to 10.1.20 in all three package.json locations (gateway-management-ui peer + dev, and components/web-console/package.json, plus the new dashboard package noted below if that lands), then regenerate pnpm-lock.yaml (pnpm install) so CI's pnpm install --frozen-lockfile installs and tests the version actually being required.

Confidence: High on the inconsistency itself (the four pins above are verifiable in-tree). Medium on downstream install behavior - in pnpm v9 lockfiles, workspace peerDependencies specifiers are not stored in the importer section, so --frozen-lockfile most likely does not fail on this change, which is precisely why the bump silently has no effect rather than erroring loudly.

Cross-PR coordination

I compared #135 against the other open PRs in openshift-online/hypershell. Open PRs at review time: #216, #214, #212, #211, #210, #209, #208, #207, #206, #201, #200, #194, #189, #188, #185, #182, #179, #151, #150, #148, #135, #109, #75, #73.

Material coordination items:

  • #209 "HYPERSHELL-112 Dashboard UI" and #214 "Hypershell-112 UI with adjustments" - Both introduce a new workspace package packages/operational-dashboard-ui/package.json that pins react-intl: 10.1.18, add react-intl imports to web-console, and regenerate pnpm-lock.yaml (which re-resolves react-intl@10.1.18). This is a genuine conflicting assumption about the canonical react-intl version plus a change-order dependency, not a mere text conflict: if #135 merges first, these PRs add a fresh consumer at 10.1.18 that violates the new 10.1.20 peer; if they merge first, #135 must also cover the new package and their regenerated lockfile. Maintainer decision needed: pick one react-intl version for the whole workspace and regenerate the lockfile once, and sequence #135 relative to #209/#214 accordingly.

  • #188 "@patternfly/react-core to v6.6.1" and #189 "@patternfly/react-icons to v6.6.1" - Both are Renovate PRs branched from the same base blob as #135 and edit the same peerDependencies block of packages/gateway-management-ui/package.json, and both exhibit the identical incomplete pattern (bump the peer only; leave the matching devDependency and the lockfile untouched). Beyond the trivial adjacent-line text conflict, the real coordination item is that all three bumps share the same systemic gap and none regenerate pnpm-lock.yaml. Maintainer decision needed: decide whether to batch #135/#188/#189 and do a single lockfile regeneration (and consistency sweep) rather than merging them independently, so the resolved versions and the lockfile end up coherent.

No other open PR presents a competing design, duplicate solution, or incompatible interface with #135.

Findings Summary (ordered by severity, highest first)

  1. [Major] react-intl bumped only in peerDependencies; devDependencies, the web-console consumer, and pnpm-lock.yaml remain at 10.1.18, so the upgrade neither takes effect nor is satisfied by its providers - Version Consistency (packages/gateway-management-ui/package.json:31, :57)

Convention Checklist

Convention Result
Image/dependency references match across the stack Fail
Conventional commit message (chore(deps): ...) Pass
Configuration separated from code Pass

Comment thread packages/gateway-management-ui/package.json
"react-dom": "19.2.8",
"react-hook-form": "7.82.0",
"react-intl": "10.1.18",
"react-intl": "10.1.20",

@jsell-rh jsell-rh Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] Incomplete bump - reconcile across the workspace.

This changes only the peerDependencies entry to 10.1.20. The matching devDependencies entry below (react-intl: 10.1.18, line 57) and the consumer components/web-console/package.json:43 (10.1.18) are unchanged, and pnpm-lock.yaml still resolves react-intl@10.1.18 everywhere (this PR touches no lockfile).

Since versions are exact-pinned, the package is still built/tested against 10.1.18, and this new exact peer (10.1.20) is satisfied by none of its providers.

Fix: bump all package.json occurrences (peer + dev here, plus web-console) and regenerate pnpm-lock.yaml so CI's --frozen-lockfile installs the version being required.

This was referenced Aug 27, 2026
Closed
Open
Open
Open
Closed
Open
Draft
Draft
Open
Open
@jsell-rh jsell-rh closed this Aug 27, 2026
@red-hat-konflux

red-hat-konflux Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (10.1.20). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@red-hat-konflux
red-hat-konflux Bot deleted the konflux/mintmaker/main/formatjs-monorepo branch August 28, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsell-rh jsell-rh jsell-rh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jsell-rh