Update link outdate - #1091
Conversation
130s
left a comment
There was a problem hiding this comment.
Just a minor question, otherwise LGTM.
| * You created a ROS 2 package and wrote your first program using MoveIt. | ||
| * You learned about using the MoveGroupInterface to plan and execute moves. | ||
| * :codedir:`Here is a copy of the full hello_moveit.cpp source at the end of this tutorial<tutorials/your_first_project/hello_moveit.cpp>`. | ||
| * :codedir:`Here is a copy of the full hello_moveit.cpp source at the end of this tutorial<tutorials/your_first_project/panda_hello_moveit.cpp>`. |
There was a problem hiding this comment.
As of today https://github.com/moveit/moveit2_tutorials/tree/cdee39bbc5746a98630a4d631ab7d0184de2f1e1/doc/tutorials/your_first_project there seems to be {kinove, panda}_hello_moveit.cpp files on this folder and github.com somehow redirects to panda. Do we need to spefically link to panda?
There was a problem hiding this comment.
Ok, I just opened the link https://github.com/moveit/moveit2_tutorials/blob/main/doc/tutorials/your_first_project/hello_moveit.cpp and it does NOT redirect to any existing file. That's not good at all, so I'm now in full support for this change. Re-approving.
There was a problem hiding this comment.
Now I dug a bit more and found using kinova makes more sense to me. Opened a follow-up #1109
|
This pull request is in conflict. Could you fix it @ntak17? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 3 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe tutorial’s full source link now references ChangesTutorial link update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized documentation link update with no actionable merge-blocking risk remaining after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…veit#1109) This reverts commit 533d176.
…veit#1109) This reverts commit 533d176.
…veit#1109) This reverts commit 533d176.

Description
Update link outdate
Summary by CodeRabbit
panda_hello_moveit.cppexample.