Skip to content

Update link outdate - #1091

Merged
130s merged 2 commits into
moveit:mainfrom
ntak17:patch-1
Aug 19, 2026
Merged

Update link outdate#1091
130s merged 2 commits into
moveit:mainfrom
ntak17:patch-1

Conversation

@ntak17

@ntak17 ntak17 commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Description

Update link outdate

Summary by CodeRabbit

  • Documentation
    • Updated the tutorial’s summary link to reference the correct panda_hello_moveit.cpp example.

@130s 130s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor question, otherwise LGTM.

* You created a ROS 2 package and wrote your first program using MoveIt.
* You learned about using the MoveGroupInterface to plan and execute moves.
* :codedir:`Here is a copy of the full hello_moveit.cpp source at the end of this tutorial<tutorials/your_first_project/hello_moveit.cpp>`.
* :codedir:`Here is a copy of the full hello_moveit.cpp source at the end of this tutorial<tutorials/your_first_project/panda_hello_moveit.cpp>`.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of today https://github.com/moveit/moveit2_tutorials/tree/cdee39bbc5746a98630a4d631ab7d0184de2f1e1/doc/tutorials/your_first_project there seems to be {kinove, panda}_hello_moveit.cpp files on this folder and github.com somehow redirects to panda. Do we need to spefically link to panda?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Can you check in here. I mean it is easy to confuse to other people followwing doc. (https://moveit.picknik.ai/humble/doc/tutorials/your_first_project/your_first_project.html)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I just opened the link https://github.com/moveit/moveit2_tutorials/blob/main/doc/tutorials/your_first_project/hello_moveit.cpp and it does NOT redirect to any existing file. That's not good at all, so I'm now in full support for this change. Re-approving.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I dug a bit more and found using kinova makes more sense to me. Opened a follow-up #1109

@130s
130s enabled auto-merge (rebase) June 17, 2026 02:30
@130s
130s disabled auto-merge August 18, 2026 22:03
@130s
130s enabled auto-merge (rebase) August 19, 2026 04:26
@130s
130s changed the base branch from humble to main August 19, 2026 04:27
@130s
130s disabled auto-merge August 19, 2026 04:28
@mergify

mergify Bot commented Aug 19, 2026

Copy link
Copy Markdown

This pull request is in conflict. Could you fix it @ntak17?

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 50517ecc-636f-4e49-acfd-2f59b78a5499

📥 Commits

Reviewing files that changed from the base of the PR and between 67792e9 and 0850e68.

📒 Files selected for processing (1)
  • doc/tutorials/your_first_project/your_first_project.rst

Included review availability: Your plan provides up to 3 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The tutorial’s full source link now references panda_hello_moveit.cpp instead of kinova_hello_moveit.cpp.

Changes

Tutorial link update

Layer / File(s) Summary
Update tutorial source link
doc/tutorials/your_first_project/your_first_project.rst
The tutorial link now points to panda_hello_moveit.cpp.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0850e

This is a localized documentation link update with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the main change: updating an outdated link in the tutorial.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@130s
130s enabled auto-merge (rebase) August 19, 2026 04:59
@130s
130s disabled auto-merge August 19, 2026 04:59
@130s
130s enabled auto-merge (squash) August 19, 2026 04:59
@130s
130s merged commit 533d176 into moveit:main Aug 19, 2026
6 of 9 checks passed
@github-project-automation github-project-automation Bot moved this to ✅ Done in MoveIt Aug 19, 2026
rhaschke pushed a commit that referenced this pull request Aug 19, 2026
130s added a commit to rhaschke/moveit2_tutorials that referenced this pull request Aug 27, 2026
130s added a commit to rhaschke/moveit2_tutorials that referenced this pull request Aug 27, 2026
rhaschke pushed a commit to rhaschke/moveit2_tutorials that referenced this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants