Skip to content

Update link outdate #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
130s merged 2 commits into from
Aug 19, 2026
Merged

Update link outdate #1091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
341acdb
fix(your_first_project.rst): Link outdated
ntak17 Apr 21, 2026
0850e68
Merge branch 'main' into patch-1
130s Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/tutorials/your_first_project/your_first_project.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ Summary

* You created a ROS 2 package and wrote your first program using MoveIt.
* You learned about using the MoveGroupInterface to plan and execute moves.
* :codedir:`Here is a copy of the full hello_moveit.cpp source at the end of this tutorial<tutorials/your_first_project/kinova_hello_moveit.cpp>`.
* :codedir:`Here is a copy of the full hello_moveit.cpp source at the end of this tutorial<tutorials/your_first_project/panda_hello_moveit.cpp>`.

@130s 130s May 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of today https://github.com/moveit/moveit2_tutorials/tree/cdee39bbc5746a98630a4d631ab7d0184de2f1e1/doc/tutorials/your_first_project there seems to be {kinove, panda}_hello_moveit.cpp files on this folder and github.com somehow redirects to panda. Do we need to spefically link to panda?

@ntak17 ntak17 Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Can you check in here. I mean it is easy to confuse to other people followwing doc. (https://moveit.picknik.ai/humble/doc/tutorials/your_first_project/your_first_project.html)

@130s 130s Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I just opened the link https://github.com/moveit/moveit2_tutorials/blob/main/doc/tutorials/your_first_project/hello_moveit.cpp and it does NOT redirect to any existing file. That's not good at all, so I'm now in full support for this change. Re-approving.

@130s 130s Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I dug a bit more and found using kinova makes more sense to me. Opened a follow-up #1109


Further Reading
---------------
Expand Down
Loading