Skip to content

Revert #1091 "Update link outdate" - #1109

Merged
rhaschke merged 2 commits into
mainfrom
revert-1091-patch-1
Aug 19, 2026
Merged

Revert #1091 "Update link outdate"#1109
rhaschke merged 2 commits into
mainfrom
revert-1091-patch-1

Conversation

@130s

@130s 130s commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Reverts #1091 for the following reasons. In a nutshell I noticed I might have merged that PR prematurely:

  • in moveit2_tutorials, kinova and panda are used extensively. I figured out kinova is preferred under doc/tutorials while only panda is in doc/examples.
  • The merged change in Update link outdate #1091, which switches kinova to panda, is under doc/tutorials where kinova should be preferred over panda as mentioned above.
  • Btw, in its original state, Update link outdate #1091 was targeted against humble branch. So an issue still remains on humble branch. That's a separate problem.

Summary by CodeRabbit

  • Documentation
    • Updated the first-project tutorial to link to the correct Kinova example source file.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 55e8e9a1-3e57-492b-8cc4-eb30a6792d40

📥 Commits

Reviewing files that changed from the base of the PR and between 533d176 and 90044f1.

📒 Files selected for processing (1)
  • doc/tutorials/your_first_project/your_first_project.rst

Included review availability: Your plan provides up to 3 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The tutorial now links to kinova_hello_moveit.cpp instead of the removed panda_hello_moveit.cpp source file.

Changes

Tutorial link update

Layer / File(s) Summary
Update tutorial source link
doc/tutorials/your_first_project/your_first_project.rst
The tutorial links to kinova_hello_moveit.cpp.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 90044

This localized documentation-only revert restores the intended tutorial link behavior and introduces no actionable merge-blocking risk beyond normal checks.

Possibly related PRs

Suggested reviewers: ntak17

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the change as a revert of PR #1091, which restores the tutorial link to the Kinova source.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-1091-patch-1

Comment @coderabbitai help to get the list of available commands.

@130s
130s marked this pull request as ready for review August 19, 2026 05:17
@130s 130s mentioned this pull request Aug 19, 2026
@130s
130s requested a review from nbbrooks August 19, 2026 15:00
@rhaschke
rhaschke merged commit 9632b90 into main Aug 19, 2026
7 of 11 checks passed
@rhaschke
rhaschke deleted the revert-1091-patch-1 branch August 19, 2026 15:27
@github-project-automation github-project-automation Bot moved this to ✅ Done in MoveIt Aug 19, 2026
130s added a commit to rhaschke/moveit2_tutorials that referenced this pull request Aug 27, 2026
130s added a commit to rhaschke/moveit2_tutorials that referenced this pull request Aug 27, 2026
rhaschke pushed a commit to rhaschke/moveit2_tutorials that referenced this pull request Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants