Skip to content

fix(minio): point MinIO image references to Quay, retiring it from CI matrix #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdelapenya merged 3 commits into from
Oct 1, 2026
Merged

fix(minio): point MinIO image references to Quay, retiring it from CI matrix #3932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9350b35
Initial plan
Copilot Oct 1, 2026
ad16f51
fix(minio): use Quay image for pinned MinIO release
Copilot Oct 1, 2026
25e63ad
docs(ci): note MinIO registry auth and exclude its CI tests
Copilot Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@ jobs:
matrix:
go-version: [1.25.x, 1.26.x]
module: ${{ fromJSON(needs.detect-modules.outputs.modules) }}
exclude:
# The Quay MinIO image requires credentials not available in CI.
- module: modules/minio
permissions:
contents: read # for actions/checkout to fetch code
pull-requests: read # for sonarsource/sonarcloud-github-action to determine which PR to decorate
Expand Down
4 changes: 3 additions & 1 deletion docs/modules/minio.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ func Run(ctx context.Context, img string, opts ...testcontainers.ContainerCustom
#### Image

Use the second argument in the `Run` function to set a valid Docker image.
In example: `Run(context.Background(), "minio/minio:RELEASE.2024-01-16T16-07-38Z")`.
In example: `Run(context.Background(), "quay.io/minio/minio:RELEASE.2024-01-16T16-07-38Z")`.

This Quay image requires registry authentication. Log in to `quay.io` with an account that has access to `minio/minio` before running the example or the module tests, or pass an image you can pull to `Run`. The Minio integration tests are excluded from CI until an accessible image is available.

### Container Options

Expand Down
2 changes: 1 addition & 1 deletion modules/minio/examples_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ func ExampleRun() {
// runMinioContainer {
ctx := context.Background()

minioContainer, err := minio.Run(ctx, "minio/minio:RELEASE.2024-01-16T16-07-38Z")
minioContainer, err := minio.Run(ctx, "quay.io/minio/minio:RELEASE.2024-01-16T16-07-38Z")
defer func() {
if err := testcontainers.TerminateContainer(minioContainer); err != nil {
log.Printf("failed to terminate container: %s", err)
Expand Down
2 changes: 1 addition & 1 deletion modules/minio/minio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (c *MinioContainer) ConnectionString(ctx context.Context) (string, error) {
// Deprecated: use Run instead
// RunContainer creates an instance of the Minio container type
func RunContainer(ctx context.Context, opts ...testcontainers.ContainerCustomizer) (*MinioContainer, error) {
return Run(ctx, "minio/minio:RELEASE.2024-01-16T16-07-38Z", opts...)
return Run(ctx, "quay.io/minio/minio:RELEASE.2024-01-16T16-07-38Z", opts...)
}

// Run creates an instance of the Minio container type
Expand Down
2 changes: 1 addition & 1 deletion modules/minio/minio_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ func TestMinio(t *testing.T) {
ctx := context.Background()

ctr, err := tcminio.Run(ctx,
"minio/minio:RELEASE.2024-01-16T16-07-38Z",
"quay.io/minio/minio:RELEASE.2024-01-16T16-07-38Z",
tcminio.WithUsername("thisismyuser"), tcminio.WithPassword("thisismypassword"))
testcontainers.CleanupContainer(t, ctr)
require.NoError(t, err)
Expand Down
Loading