Remove custom memos from tempo - #76
Merged
Merged
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
ksn-stripe
changed the title
ksn-stripe
marked this pull request as ready for review
September 18, 2026 15:42
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
Contributor
|
LGTM |
brendanjryan
approved these changes
Sep 18, 2026
This was referenced Sep 18, 2026
brendanjryan
added a commit
to tempoxyz/mpp-go
that referenced
this pull request
Sep 24, 2026
Remove custom primary Tempo charge memos, matching [mppx #904](wevm/mppx#904) and [mpp-rb #76](stripe/mpp-rb#76). Clients always generate attribution memos bound to the challenge and realm, and both calldata and receipt verification require that binding. Breaking API change: remove primary `Memo` fields from charge parameters, method configuration, and method details. Legacy primary memo fields are ignored when parsing requests; split-specific memos remain supported. Includes a release note and updated client, request, and verification tests. Validation: `go test ./...`, `go vet ./...`, and formatting passed with Go 1.26.0. Live-chain integration tests were not run. Prompted by: @brendanjryan Co-authored-by: Brendan Ryan <1572504+brendanjryan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change. Remove custom memo capability for tempo servers to match the security fix from stripe/mpp-java#31.