fix(tempo): remove custom primary charge memos - #421
Merged
Merged
Conversation
decofe
requested review from
brendanjryan,
mattsse and
onbjerg
as code owners
September 18, 2026 17:33
Contributor
✅ Changelog found on PR. |
brendanjryan
approved these changes
Sep 18, 2026
brendanjryan
enabled auto-merge (squash)
September 21, 2026 15:10
Co-authored-by: Derek Cofausper <256792747+decofe@users.noreply.github.com>
brendanjryan
force-pushed
the
centaur/remove-custom-charge-memos-1789747200
branch
from
September 21, 2026 15:16
87291e8 to
642373e
Compare
brendanjryan
approved these changes
Sep 21, 2026
brendanjryan
deleted the
centaur/remove-custom-charge-memos-1789747200
branch
September 21, 2026 15:23
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove custom primary Tempo charge memos, matching mppx #904 and mpp-rb #76. Clients generate attribution memos bound to the challenge and realm, and both hash and transaction receipt verification always require that binding.
Breaking API change: remove
TempoMethodDetails.memoand theTempoChargeExt::memoaccessor. Legacy primary memo fields are ignored when reading challenges; split-specific memos remain supported. The low-level charge constructor also generates a bound memo, and the provider includes its configured client attribution. Includes a release note and updated client/routing tests.Validation: 1,053 unit tests passed with client, server, Tempo, and Stripe features (sandbox hostname unset to preserve the suite's default realm); full-workspace, all-target, all-feature Clippy with warnings denied and formatting passed through nightly. Live-chain integration tests were not run.
Prompted by: @brendanjryan