Skip to content

Ef misc sizing fixes - #38

Open
eric-adstage wants to merge 5 commits into
pablosichert:masterfrom
eric-adstage:ef-misc-sizing-fixes
Open

Ef misc sizing fixes#38
eric-adstage wants to merge 5 commits into
pablosichert:masterfrom
eric-adstage:ef-misc-sizing-fixes

Conversation

@eric-adstage

Copy link
Copy Markdown

Hey @pablosichert - I still can't get the tests passing, but here are the changes I want to make for handling padded containers and letter spacing. Any thoughts?

@eric-adstage
eric-adstage force-pushed the ef-misc-sizing-fixes branch from 4714ec5 to f8487e4 Compare March 11, 2017 18:37
@eric-adstage

Copy link
Copy Markdown
Author

Ping! Just wanted to make sure you saw this @pablosichert.

@pablosichert

Copy link
Copy Markdown
Owner

Changes look good!

Let's come back to this after merging and rebasing on #37.

@eric-adstage
eric-adstage force-pushed the ef-misc-sizing-fixes branch from f8487e4 to f1edb23 Compare March 28, 2017 17:46
@eric-adstage
eric-adstage force-pushed the ef-misc-sizing-fixes branch from f1edb23 to 86352e5 Compare March 28, 2017 17:47
@eric-adstage

Copy link
Copy Markdown
Author

@pablosichert With my latest timeout patch commit, the build passes for me locally, but fails on Travis -- do you have any idea what might be going on? It's stalling out at some point, and then the build dies after 10 minutes of inactivity.

Also, if you have any insight into why the "should recalculate when resizing the window" test would be timing out for me locally, that would be awesome. If there's some fix for that besides upping the default 2000ms timeout, it might fix the Travis issue too. Not sure if there's some inefficiencies I might have inadvertently introduced with my patches that I'm just not seeing.

@eric-adstage

Copy link
Copy Markdown
Author

Hey @pablosichert - Just wondering if you'd had a chance to look into this PR yet.

@iamakulov

Copy link
Copy Markdown

@pablosichert @eric-adstage I’d love to see this released. How can I help here?

@eric-adstage

eric-adstage commented Aug 17, 2017

Copy link
Copy Markdown
Author

@iamakulov @pablosichert seems to have gone dark -- not sure what happened!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants