Skip to content

added parentNode padding to targetWidth calculation - #44

Closed
tulburg wants to merge 4 commits into
pablosichert:masterfrom
tulburg:src/Truncate.js
Closed

tulburg wants to merge 4 commits into
pablosichert:masterfrom
tulburg:src/Truncate.js

Conversation

@tulburg

@tulburg tulburg commented May 5, 2017

Copy link
Copy Markdown

In case the truncate text's parent has paddingLeft or paddingRight or both, truncate needs to consider that in targetWidth calculation.

@pablosichert

Copy link
Copy Markdown
Owner

Thanks for your PR, this one is addressing the same problem: #38.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants