Skip to content

mls (v5.7)#4417

Merged
Celant merged 2 commits into
openfrontio:v32from
Aotumuri:mls-5-7
Jun 28, 2026
Merged

mls (v5.7)#4417
Celant merged 2 commits into
openfrontio:v32from
Aotumuri:mls-5-7

Conversation

@Aotumuri

Copy link
Copy Markdown
Member

Description:

Version identifier within MLS: v5.7

[Changed languages]

  • cs
  • da
  • eo
  • fa
  • fr
  • hu
  • ja
  • ru
  • uk
  • zh-CN

[Change volume]

  • Changed languages: 10
  • Changed files: 10
  • Changed lines: 21351
  • metadata.json: unchanged

Final reviewer: meow

This PR was generated by the PR sender tool, then checked and submitted by the final reviewer.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 91224d6e-3b7f-4877-bc9d-c41e71279a9c

📥 Commits

Reviewing files that changed from the base of the PR and between 2709c50 and 492c515.

📒 Files selected for processing (2)
  • resources/lang/da.json
  • resources/lang/fr.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • resources/lang/da.json

Walkthrough

Locale JSON files were expanded across Czech, Danish, Esperanto, Persian, French, Hungarian, Japanese, Russian, and Ukrainian. The update revises shared UI text, gameplay overlays, map browsing and favorites, replay/store flows, and settings, accessibility, and validation strings.

Changes

Locale translation refresh

Layer / File(s) Summary
Shared locale text
resources/lang/*.json
Locale metadata and early account, build-menu, chat, clan, control-panel, cosmetics, and event strings are expanded or revised.
Gameplay overlays and lobby
resources/lang/*.json
Help, graphics, host, leaderboard, matchmaking, map-navigation, and lobby strings are expanded.
Map browser and favorites
resources/lang/*.json
Map entries, map categories, and favorites component strings are updated.
Tail-end flows and settings
resources/lang/*.json
Replay, store, system, accessibility, user-setting, username, and win-modal strings are expanded.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

Translation

Suggested reviewers

  • evanpelle
  • Duwibi

Poem

Nine tongues hum in tidy rows,
maps and menus softly glow.
Lobbies count down, settings shine,
each little key falls into line.
A JSON choir sings just right ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title matches the version update, but it is too terse and not descriptive enough on its own. Use a clearer title like “Update MLS to v5.7 across 10 locale files” so the main change is easy to scan.
✅ Passed checks (4 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the locale/version update and change summary, so it is on-topic.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@resources/lang/da.json`:
- Line 568: The pvp_immunity_active translation in the da.json locale renders
the countdown as "{seconds}er", which produces awkward HUD text; update this
string so the placeholder is followed by a readable separator or localized
suffix. Locate the pvp_immunity_active entry and adjust the wording to keep the
countdown human-friendly while preserving the seconds placeholder.
- Line 806: The avatar alt text translation is malformed because the {username}
placeholder is broken in the user_avatar_alt entry. Update the string in the
Danish locale so the placeholder is preserved correctly and the alt text renders
with the username as intended. Use the user_avatar_alt key in
resources/lang/da.json to locate and fix the value.

In `@resources/lang/eo.json`:
- Line 57: The locale entry for city is using the wrong mechanic description, so
update the shared city key in the Esperanto translation to match the other
locale files and describe max population instead of truplimo. Make the same
correction wherever the city label appears in this file, keeping the wording
aligned with the build menu and help modal usage for the city key.

In `@resources/lang/fr.json`:
- Line 6: The French flag icon ID referenced in the language mapping does not
resolve to any known asset or registry entry. Update the `fr.json` language
entry to use an existing flag ID, or add `fr_french_flag` to the assets and icon
mapping so the language picker can resolve it correctly. Use the `svg` key in
the French locale file and ensure the chosen ID matches whatever the icon lookup
code expects.

In `@resources/lang/hu.json`:
- Around line 358-364: The cosmetics translation block has one mixed-language
rarity label: update the cosmetics.epic entry in the Hungarian locale to a
proper Hungarian translation so it matches the neighboring labels. Keep the
change localized within the cosmetics object in the language JSON and ensure the
shop UI uses consistently translated rarity names.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fa2f7a83-12bf-433d-89d5-4040a011a650

📥 Commits

Reviewing files that changed from the base of the PR and between b22f422 and 2709c50.

📒 Files selected for processing (10)
  • resources/lang/cs.json
  • resources/lang/da.json
  • resources/lang/eo.json
  • resources/lang/fa.json
  • resources/lang/fr.json
  • resources/lang/hu.json
  • resources/lang/ja.json
  • resources/lang/ru.json
  • resources/lang/uk.json
  • resources/lang/zh-CN.json

Comment thread resources/lang/da.json
Comment thread resources/lang/da.json Outdated
Comment thread resources/lang/eo.json
Comment thread resources/lang/fr.json Outdated
Comment thread resources/lang/hu.json
@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management Jun 26, 2026
@iiamlewis

Copy link
Copy Markdown
Contributor

@Aotumuri (via Discord):

wa?

@Aotumuri Aotumuri marked this pull request as draft June 26, 2026 12:47
@Aotumuri

Copy link
Copy Markdown
Member Author

DO NOT MERGE YET.
This PR contains a critical mistake.

@Aotumuri Aotumuri marked this pull request as ready for review June 28, 2026 06:48
@Celant Celant merged commit ab95e03 into openfrontio:v32 Jun 28, 2026
9 of 10 checks passed
@github-project-automation github-project-automation Bot moved this from Development to Complete in OpenFront Release Management Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants