mls (v5.7)#4417
Conversation
|
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughLocale JSON files were expanded across Czech, Danish, Esperanto, Persian, French, Hungarian, Japanese, Russian, and Ukrainian. The update revises shared UI text, gameplay overlays, map browsing and favorites, replay/store flows, and settings, accessibility, and validation strings. ChangesLocale translation refresh
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/lang/da.json`:
- Line 568: The pvp_immunity_active translation in the da.json locale renders
the countdown as "{seconds}er", which produces awkward HUD text; update this
string so the placeholder is followed by a readable separator or localized
suffix. Locate the pvp_immunity_active entry and adjust the wording to keep the
countdown human-friendly while preserving the seconds placeholder.
- Line 806: The avatar alt text translation is malformed because the {username}
placeholder is broken in the user_avatar_alt entry. Update the string in the
Danish locale so the placeholder is preserved correctly and the alt text renders
with the username as intended. Use the user_avatar_alt key in
resources/lang/da.json to locate and fix the value.
In `@resources/lang/eo.json`:
- Line 57: The locale entry for city is using the wrong mechanic description, so
update the shared city key in the Esperanto translation to match the other
locale files and describe max population instead of truplimo. Make the same
correction wherever the city label appears in this file, keeping the wording
aligned with the build menu and help modal usage for the city key.
In `@resources/lang/fr.json`:
- Line 6: The French flag icon ID referenced in the language mapping does not
resolve to any known asset or registry entry. Update the `fr.json` language
entry to use an existing flag ID, or add `fr_french_flag` to the assets and icon
mapping so the language picker can resolve it correctly. Use the `svg` key in
the French locale file and ensure the chosen ID matches whatever the icon lookup
code expects.
In `@resources/lang/hu.json`:
- Around line 358-364: The cosmetics translation block has one mixed-language
rarity label: update the cosmetics.epic entry in the Hungarian locale to a
proper Hungarian translation so it matches the neighboring labels. Keep the
change localized within the cosmetics object in the language JSON and ensure the
shop UI uses consistently translated rarity names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: fa2f7a83-12bf-433d-89d5-4040a011a650
📒 Files selected for processing (10)
resources/lang/cs.jsonresources/lang/da.jsonresources/lang/eo.jsonresources/lang/fa.jsonresources/lang/fr.jsonresources/lang/hu.jsonresources/lang/ja.jsonresources/lang/ru.jsonresources/lang/uk.jsonresources/lang/zh-CN.json
|
@Aotumuri (via Discord): wa? |
|
DO NOT MERGE YET. |
Description:
Version identifier within MLS: v5.7
[Changed languages]
[Change volume]
Final reviewer: meow
This PR was generated by the PR sender tool, then checked and submitted by the final reviewer.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
aotumuri