Conversation
- Moves and refactors components to be generic and be used in both CourseCard and PathwayCard - Creates the PathwayCard with all extra components
- Rename some components, files and directories to match 'items' instead of only courses - Add Pathways to the filters and sorting - Add Types filter
|
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #860 +/- ##
==========================================
+ Coverage 98.19% 98.39% +0.20%
==========================================
Files 145 162 +17
Lines 1388 1687 +299
Branches 297 363 +66
==========================================
+ Hits 1363 1660 +297
- Misses 25 27 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
navinkarkera
left a comment
There was a problem hiding this comment.
@ChrisChV Looks good. Found one issue where the types filter is visible even when we set ENABLE_PATHWAY_PILOT_UI=false. Please take a look at the suggestions below.
|
@navinkarkera Also in 2932921 I refactored the code to use the |
|
Heads up: the frontend-base conversion of Learner Dashboard will in all likelihood land before this PR. (See the announcement.) I apologize for the inconvenience, but once that happens (probably this week), the feature will have to be refactored accordingly. I suggest not closing this PR, though: once the |
|
Hey @ChrisChV, if you haven't already could you follow up on Adolfo's comment above and see if this is unblocked for next steps (= if the |
|
@ChrisChV Also, since this is part of the Pathways Pilot can we consider it approved from a product perspective? (Asking because I'm not completely sure what the status of that project is in terms of approval for relevant designs.) |
@itsjeyd Yes, the designs changed after this implementation was completed. I want to wait until they are finished and validated before continuing. |
|
@navinkarkera @ChrisChV OK, thanks for the info. I'll label this as |
Description
PathwayCardCourseCardto be reusable.ENABLE_PATHWAY_PILOT_UIflag.Types.Iteminstead ofCourseSupporting information
Testing instructions
ENABLE_PATHWAY_PILOT_UIENABLE_PATHWAY_PILOT_UINotes