Skip to content

[codex] disable Nagle on Rendezvous WebSockets #30269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardopenai wants to merge 8 commits into
base: main
Choose a base branch
from
+2 −2
Open

[codex] disable Nagle on Rendezvous WebSockets #30269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7426e92
exec-server: disable Nagle on Rendezvous websockets
richardopenai Jun 26, 2026
41213bb
exec-server: explain disabled Nagle
richardopenai Jun 26, 2026
2ee4fe5
Gate Rendezvous TCP_NODELAY rollout
richardopenai Jun 27, 2026
de14d76
Revert "Gate Rendezvous TCP_NODELAY rollout"
richardopenai Jun 27, 2026
f05e1a8
Gate Rendezvous TCP_NODELAY by signed path
richardopenai Jun 27, 2026
ce3088c
Consolidate TCP_NODELAY path tests
richardopenai Jun 27, 2026
61ca24a
Make Rendezvous TCP_NODELAY unconditional
richardopenai Jun 27, 2026
f20b2c8
Merge remote-tracking branch 'origin/main' into codex/exec-server-ren…
richardopenai Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codex-rs/exec-server/src/client_transport.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ impl ExecServerClient {
connect_async_with_config(
request,
Some(noise_relay_websocket_config()),
/*disable_nagle*/ false,

@richardopenai richardopenai Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put a pr comment explaining this

/*disable_nagle*/ true,
),
)
.await
Expand Down
2 changes: 1 addition & 1 deletion codex-rs/exec-server/src/remote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ async fn connect_rendezvous(
connect_async_with_config(
request,
Some(noise_relay_websocket_config()),
/*disable_nagle*/ false,
/*disable_nagle*/ true,
)
.await
.map(|(websocket, _)| websocket)
Expand Down
Loading