[codex] disable Nagle on Rendezvous WebSockets#30269
Open
richardopenai wants to merge 8 commits into
Open
Conversation
This was referenced Jun 26, 2026
Contributor
Author
|
CI diagnosis: the broad Bazel, clippy, release, and argument-comment jobs are failing on the PR base, before reaching this two-line change. The shared error is |
Contributor
Codex Cloud Agents (CCA) couldn't complete this review. The original Codex Review is unaffected. |
richardopenai
commented
Jun 26, 2026
| connect_async_with_config( | ||
| request, | ||
| Some(noise_relay_websocket_config()), | ||
| /*disable_nagle*/ false, |
Contributor
Author
There was a problem hiding this comment.
put a pr comment explaining this
richardopenai
force-pushed
the
codex/exec-server-rendezvous-tcp-nodelay
branch
from
5a1272c to
41213bb
Compare
miz-openai
approved these changes
Jun 26, 2026
owenlin0
approved these changes
Jun 26, 2026
owenlin0
left a comment
owenlin0
left a comment
Collaborator
There was a problem hiding this comment.
🤷 trust that this is the right thing to do?
richardopenai
changed the title
richardopenai
changed the title
richardopenai
changed the title
…dezvous-tcp-nodelay
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable Nagle unconditionally for both exec-server Rendezvous WebSocket connections.
disable_nagle=trueat the executor and harness connection call sitesThe companion internal PR enables
TCP_NODELAYon accepted Rendezvous sockets: https://github.com/openai/openai/pull/1082463Why
Rendezvous carries small, latency-sensitive relay and JSON-RPC frames. Three staging runs of 30 steady-state
process/readcalls per configuration measured p50 improving from 139.1 ms to 81.5 ms and p95 from 162.0 ms to 95.8 ms with Nagle disabled.The expected packet overhead is small at the current connection scale. We will use existing latency, error, packet, and CPU monitoring and revert normally if production regresses.
Rollout and rollback
The client and accepted-socket changes can deploy independently. New connections receive the setting as each side deploys. Rollback is a normal code revert; there is no persisted assignment or gate state to unwind.
Validation
just test -p codex-exec-server --lib: 164 passedjust fix -p codex-exec-server: passedjust fmt: passed