Repository navigation
Document async adapters and move the weather example onto them - #981
Open
philocalyst wants to merge 25 commits into
Open
philocalyst wants to merge 25 commits into
philocalyst wants to merge 25 commits into
Conversation
This was referenced Sep 5, 2026
philocalyst
force-pushed
the
stack/6-async-docs-and-weather
branch
from
September 5, 2026 20:48
f0351aa to
c10074b
Compare
philocalyst
force-pushed
the
stack/6-async-docs-and-weather
branch
from
September 5, 2026 20:58
c10074b to
61416e8
Compare
philocalyst
force-pushed
the
stack/6-async-docs-and-weather
branch
from
September 5, 2026 22:23
61416e8 to
8115ec1
Compare
philocalyst
force-pushed
the
stack/6-async-docs-and-weather
branch
from
September 6, 2026 05:26
8115ec1 to
7fc8292
Compare
philocalyst
marked this pull request as ready for review
September 6, 2026 05:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The end of the refactoring. The adoption half of #980 and #982, copying what #978 did for the synchronous fallible API. Docs, one example, and a dev shell, no library code.
Documentation
The Rust Adapters guide gets its async continuation: the direct
AsyncAdapter/AsyncBasicAdapterpath, the explicitFallibleAsyncAdapterpath, and the two edge-error boundaries.The weather example
trustfall/examples/weathermoves toAsyncBasicAdapterandexecute_query_async(), gated behindrequired-features = ["async"].To be upfront about it: its data source is a local CSV file, so there is no IO to overlap here. The example earns its place by showing the shape of an async adapter, so stream construction, the helper imports, driving the result stream; it's not actually quicker. If you'd want a better example, I can make one, just was getting tired, lmao.
Migration
None. Documentation, one example, and a dev shell.
Stack
Final PR in the stack. Depends on #982.
Thanks for reading all seven of these. I know it's a lot to put in front of someone at once. If you'd like a different approach, let me know.
Validation
(CI CHECKS)
--all-features--all-features