Repository navigation
Document fallible adapters and adopt them in the live demo - #978
Open
philocalyst wants to merge 12 commits into
Open
philocalyst wants to merge 12 commits into
philocalyst wants to merge 12 commits into
Conversation
This was referenced Sep 5, 2026
philocalyst
force-pushed
the
stack/3-fallible-docs-and-demo
branch
from
September 5, 2026 20:48
4d0970f to
036d7d6
Compare
philocalyst
force-pushed
the
stack/3-fallible-docs-and-demo
branch
from
September 5, 2026 20:58
036d7d6 to
339b8be
Compare
philocalyst
marked this pull request as ready for review
September 6, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With our new contracts and API methods in place, this is the first demo that proves why this is valid. Pretty smol
Documentation
Added a real Adapters guide.
Adapter/BasicAdapterstay the default and stay deliberately result-free.FallibleAdapterandtry_execute_query()are the opt-in for sources that can actually fail.FallibleAdapterto model an infallible source. The direct traits make the common case smaller and easier to read, and that's the whole point of having two traits. If the guide doesn't land that, the two-trait design was a waste.The live demo
demo-hytradboimoves toFallibleDemoAdapter. Its Hacker News starting edges hit the network, and until now a failed request got printed to stderr and silently dropped mid-query, you get a short result set with no indication that anything went wrong, too bad. With this new future on the way, you see real Result rows to make decisions on.The pure resolver logic stays on
DemoAdapter. Only the boundary that can actually fail moves, which is exactly the migration the guide describes. (yay consistency)Migration
None for library users. Documentation and a demo binary.
Stack
Depends on #977, which introduces
FallibleAdapterandtry_execute_query().Cross-fork PRs can only be based on
main, so the diff is cumulative. The two commits unique to this PR areAdd a Rust adapters guide to the docsandMove the live demo to a fallible adapter.Validation
(CI CHECKS)