Skip to content

Use components.json instead of github repo as modules version cache#4396

Draft
mashehu wants to merge 3 commits into
nf-core:devfrom
mashehu:http-registry-2
Draft

Use components.json instead of github repo as modules version cache#4396
mashehu wants to merge 3 commits into
nf-core:devfrom
mashehu:http-registry-2

Conversation

@mashehu

@mashehu mashehu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.53226% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.00%. Comparing base (b559ed4) to head (9f3e174).

Files with missing lines Patch % Lines
nf_core/modules/registry_client.py 93.81% 12 Missing ⚠️
nf_core/components/components_utils.py 76.47% 4 Missing ⚠️
nf_core/components/components_command.py 40.00% 3 Missing ⚠️
nf_core/modules/modules_json.py 80.00% 2 Missing ⚠️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jul 17, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 64.16%

⚡ 1 improved benchmark
✅ 8 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_modules_install_startup 7 s 4.3 s +64.16%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mashehu:http-registry-2 (9f3e174) with dev (b559ed4)

Open in CodSpeed

mashehu added 3 commits July 17, 2026 15:14
(cherry picked from commit 47b36b0)

# Conflicts:
#	nf_core/modules/lint/main_nf.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant