Log subworkflow dependencies on install (#3871)#4357
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
d61a348 to
3b2c774
Compare
|
failing pytests are fixed in 2cf4c36 |
504c62d to
a8a0603
Compare
|
@nf-core-bot fix linting |
|
| installed_components = [] | ||
| installed_components.append(component) |
There was a problem hiding this comment.
| installed_components = [] | |
| installed_components.append(component) | |
| installed_components = [component] |
| assert samtools_flagstat_path.exists() | ||
|
|
||
| def test_subworkflows_install_logs_dependencies(self): | ||
| """Installing a subworkflow should log its module dependencies (#3871).""" |
There was a problem hiding this comment.
| """Installing a subworkflow should log its module dependencies (#3871).""" | |
| """Installing a subworkflow should log its module dependencies.""" |
| self.force = False | ||
| try: | ||
| self.install_included_components(component_dir) | ||
| self.install_included_components(component_dir, installed_components) |
There was a problem hiding this comment.
is the installed_components really needed? it just contains component here. better that install_included_components returns a list of installed components that we then use to log
or maybe just move the logging to the loop inside install_included_components, so we don't need to log anything on a higher level
Mirror remove.py by logging installed components and their dependencies during subworkflow install, and add a test for the dependency log output.
2 participants
Mirror remove.py by logging installed components and their dependencies during subworkflow install, and add a test for the dependency log output.