Repository navigation
Conversation
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 21, 2026 12:55
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read diagnostic source snippets without eagerly constructing a TypeScript AST. Forwarded-handler evidence parses the cached source snapshot only when its AST is needed. This removes unused TypeScript loader work while preserving diagnostic spans, snippets, fingerprints, and the report shape.
Regression coverage includes UTF-8 byte offsets, CRLF, cached source snapshots, option changes, file failures, and lazy parser failures. The existing forwarded-handler and scan-cache suites remain covered.
Validation: all required test, lint, typecheck, format, generator, build, and JSON smoke commands exited zero; 62 focused evidence/cache tests passed. The committed build has 175 verified own artifacts and five verified runtime edges. The strict intermediate artifact audit retained one declaration-only literal-union ordering failure; an independent exact-byte review qualified that finite type-equivalent difference, with the other 174 artifacts and JavaScript unchanged.
On one synthetic general workload with 128 components, 11 selected files, and 256 exact diagnostic objects, nine samples per revision/cohort measured cold median 852.8→733.6 ms and hot 432.0→381.4 ms. Total CPU and maximum RSS decreased in both cohorts. Dedicated CPU/rule captures were separate; 10,672 raw CPU samples had no discarded nonpositive offsets. Hot primary-rule attribution remains partial. These results cover this finite local workload; affected rule branches are validated separately.
The patch Changeset applies to
react-doctor. Package versions remain 0.9.18. Hosted parity and RDE were not run because their credentials were unavailable; no hosted parity claim is made.