Skip to content

fix: consolidate reviewed false-negative detector fixes - #2243

Draft
aidenybai wants to merge 1 commit into
mainfrom
codex/mega-fn-20261025
Draft

aidenybai wants to merge 1 commit into
mainfrom
codex/mega-fn-20261025

Conversation

@aidenybai

@aidenybai aidenybai commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Why

Combine the reviewed false-negative fixes into one candidate so their interactions can be validated against the same main commit. The fixes cover missed unsafe state updates, callback and alias flows, cleanup paths, and related diagnostic controls.

What changed

  • Integrate 55 FN sources and 33 shared prerequisites from the frozen set of 219 ready source PRs.
  • Repair integration defects found by the build, fuzz smoke tests, and typechecking: a duplicate semantic-context accessor, a stale readonly-symbol callback, and a missing find-guard context argument.
  • Add combined find-predicate alias regressions and update two stale test expectations to match this branch's rule contracts.
  • Preserve the existing patch changesets. Pending draft sources are outside this frozen candidate.

Validation

  • Exact-head CI passed all seven test-matrix jobs across Ubuntu, macOS, and Windows, covering Node 20.19 through 26.
  • All seven typechecks, lint, formatting, JSON report smoke validation, and published-dependency checks passed.
  • Strict fuzzing passed all 43 groups covering 44 changed-rule IDs, with 500 iterations and seed 42; every target produced diagnostics. The full 907-rule, 100-iteration invariant sweep also passed. Across both phases, 425,283 programs executed with no findings or advisories.
  • One activated healthy-store control passed cold, hot, and no-cache profiles: 42 total CLI runs including warmups and dedicated CPU/rule captures. All full diagnostic objects matched the expected warning; CPU, individual peak RSS, and wall time cleared the frozen gates. Other cases remain pending.

Remaining before ready

  • Exact-head CI, including the whole package test suite.
  • Public CLI activation and CPU, peak RSS, and wall-time profiles for the integrated changes.
  • Full paired parity on the pinned 2,000-project corpus, followed by diagnostic-delta review.
  • Final mergeability and review-thread check.

This PR stays draft until those checks are complete. Full paired parity ran main 84ad0c8d0df7a3ab7d26946367fae3bc39c100d0 against this exact head 75e5c452341eafda16aa80f65a54e6a07d410801: 1,991 of 2,000 project pairs completed, with nine failures after retries. Seven repository metadata lookups return 404 and one pinned commit is unavailable. The remaining project reproduced a 120-second dead-code analysis timeout on both revisions. Both CLI commands exited zero but emitted incomplete reports, which the stock validator rejected.

The full captured reports, failed-project records, output hashes, and verification evidence are retained. The nonzero parity streams were verified and discarded without comparison or caching. A revised 2,000-project corpus replaces the nine unusable inputs; a fresh complete paired run and diagnostic-delta review remain pending. No parity or broad performance pass is claimed.

Included source PRs and frozen heads (88)
Source Placement Frozen head
#1944 COMMON 4b4fbd3f5ebf825b99025df80e1ca6009181c305
#1945 COMMON 7b6a8e406fac053a3b0a821f8ffa91781187379f
#1958 COMMON 3251494c27f1704767d0f47ddbee67f2511063d5
#1960 FN e8617d526c01671f5f29534cde0da25e4bcf2624
#1967 FN f9fcbed8e1be5009c3b38b34b9950b4e75400cfe
#1969 FN 93bd0d8da646b1f8ccd26e337cc3e0c3197620f3
#1970 COMMON fab43a3ac7fc9935493a2f95837fa53de1217096
#1972 FN 855a2d9fa86d80c20e6a6ff9346034597912ebe5
#1978 FN 665c1e1d593534ecb5d61bd968e62424d192cdd9
#1979 FN 5be5043696ae30a44dec0ea58b7064a9bd80727c
#1980 FN e0c69e3a4d0e07cf1944eb1ac0e02da5a14afbff
#1981 FN 1b9e9c057c1739b48e8f174d790d5f6716b00692
#1985 FN 6ab5f59db4f7da3cf8cef7ef3a358f77a84d8fdb
#1986 FN 86ca210b97d22dc78a03de40c1b9b4b564de196b
#1989 FN 1f32c40da800e3aba376ba9c9391d60307b348bb
#1992 COMMON 1f7953c59095b1a43bbc0b0ca2a5854ac0eda690
#1994 COMMON 898e6d3c6496f94a83b22f0956ce40419a950197
#2001 COMMON 4d6a7ed6bb2e743c711fd2ea20df5036a0c3a94e
#2002 COMMON f677dbe4e00907c4904ea1e3069e56089b219ed0
#2003 COMMON 8fccdb1a5bd7bc6c87551e06e2a767e2c73f29f1
#2008 FN 50cb18d0c3b108815b72095c621e8e548fbd4c89
#2012 FN 5c4b6c3d9b51c6ed6f3e75e63ee043116fef2f6a
#2013 FN b8b9fd3a720fb325e34920227692f3e3eb575d3a
#2016 COMMON cfc7c4b1bba2996d72ebaaee8f7fae004f2a419a
#2017 FN d0efb8bf3d20623b2911d416c82515508b3a8c68
#2020 FN 2ec2a6bed982e45007484b1eefd85dd8e7b8c8dc
#2026 COMMON 130ab17161402cbb9277b0f5fa144b86ecb6442a
#2028 FN f74e04e1098c2c153717f34ca1ac9db1c4a0f45a
#2031 COMMON 9d7880c2b25d953bdb79591f8349fc23fcfb5233
#2035 COMMON 31e39a5d115169f00e79e6683384c22d7aac68c0
#2039 FN 73fb9048ce886ddb3e926d576137fe1e7284e411
#2041 FN 155637de0752b68ebd2a8875500847d61b93664e
#2042 COMMON a9f8766fe394bbb40969d8b806523fd4fe7618c8
#2043 FN 2b64f09b4442d7cd43e748a0f7805791edd45c19
#2050 FN a1362204ed3e20301cb3c97c473886c7e7079f28
#2051 FN 15c7f03194dbf556589b405e0d27215edc8ef973
#2052 FN dbeebc173b8d37f90d9d5ab52cac62670355f66d
#2053 COMMON 638b705bed85b41ad30392cec1f2a92c3783cdaf
#2054 FN 1b3b31d21ff7ea5b518a497000de0bc76d7472f5
#2055 COMMON cb70dcca42c238811447935d1112d0730c3f4d18
#2056 COMMON 11d2a8d86c424e01281e22e30915f3afa1484cda
#2059 FN f029588bec4d84ef678813c9aeeda43ac05a1b24
#2060 FN 3b80c9976d0337b06417b6950d8527f3f9baee90
#2063 FN 7344b3141c5fb2d3aab80a7a595940c1f9ed0f50
#2070 FN 1ba08604880e3ff274dfc7f7c53e5500336eb9e4
#2072 COMMON e799ac8f0ca492a5dce0612946f2d7cfdaa0ba6b
#2073 FN 8f0d128a02230e5a0c4663a6dde24eb041aad6c7
#2076 COMMON 09f19e19134ab00541f58fc027ce9a3a1d5ac142
#2077 FN 148e1f3189f96af356eaf0e4acb0e1b07c59d0c6
#2079 COMMON 15bd306c832158c89810b62cb48a6168e6f5fcd2
#2082 FN bd0c67ad40cc6fa60d2954beb23a46f1f3b50a95
#2085 COMMON 92154a1d98bb5c3ca1299460245141714d64ceec
#2092 FN 588de9642d0b9d0bc382e0ff7c3c9cdbfb0686a3
#2097 FN 986bc9c95dfaad0e074c8b3756439bdef1804218
#2106 FN aa66edcb8a2752effdd87396fc77abfe3cb12592
#2108 FN 8201239e9bcf90779d875e457d80c1e1a32c6c94
#2111 FN 2aa48a8d95845fc4deace4fd5159ccb76a5d5640
#2117 COMMON 62ed51327c9b5e33e543bd72b531a3372cddc75d
#2120 FN 2ad7a54b78ae7eef6d427db0d958125e1190f6af
#2122 FN b04ce6cf9551e5b3d4126f7f7d3369c036976dcc
#2127 COMMON 4e739b8edccbe2091977ab7530a1c321b3ae2d1d
#2129 FN 1cfbda34f2a475a163d0483bab8c17d97ad90662
#2130 FN 6080e622333b149b38c8fb3e7c7068e32cc88529
#2131 FN 96d742af9debec974c9f8b989336ae1cad01b062
#2132 FN 0d106834f1404e7e1534e71ef33193a5f4219fee
#2133 FN 1ab476ad12d3c39b6295bc82144f4fd9cc38aa4e
#2134 COMMON 41cc16a764e1a0736829d30c8decc8f83cd60a7f
#2135 COMMON 256d8bcc92cf42e395f1bd3164cf52185161c626
#2136 FN 0d246e1e8a3ab4a502b94b4016b57c81f1628d05
#2138 FN 0eb3c85e4d36041c8c5d5ba99fe4a8095053dc81
#2142 FN a1b53f7254551e2678003b54fd8abd32cbaa4749
#2143 FN f324be7b0c55ae56050054a3747374cb02589185
#2144 COMMON e701f397a7dab9367497006026414f6919ad4f41
#2145 FN 4aa25ac06f7dc16de5a4fac4c97df019367f7cd3
#2147 FN 92e48ec71e2763a9cce808c4c4484e6e6239dc04
#2148 FN 8c8ce9a15062d707c33091c37a22160f362076a1
#2149 FN 513d097bdaefd2bfe785af7660ccbb2706d8d7c9
#2153 FN 24e46e231be29612b77915b874e471f60c9ad47a
#2161 FN 45bae529c7660755249a4290bc395da11023daaf
#2166 COMMON b6048235d39ce8b7ed58885bf2fac377251bcc67
#2167 COMMON 8fb68f815f786262eb570c09727e380dfbe6fbb4
#2171 COMMON 04ff55b9163f399ba43454c0ad3df397c67ef634
#2177 COMMON adcd927bf16bc8d0c48b873ca7162a43e531cf9d
#2178 COMMON e3428ee8863acd3e3519f818b9ecddb9d3ee5105
#2186 FN 706a29c77d362ea4183d77dc40fcc4e6eaea2e7b
#2187 COMMON dbf4cf51b19b35c94e33e96c9231fe5b70075bfa
#2188 FN adc31530403ea34d912bedbd013d15c074b5f7d9
#2189 COMMON 96ebb5a554784884336c120c04db3d75a7d153f9

@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@2243
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@2243
npm i https://pkg.pr.new/react-doctor@2243

commit: 75e5c45

@github-actions

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit 75e5c45.

@github-actions

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

Terminal Control verified the built CLI at 75e5c45 in a real PTY:

  • selected a project interactively and observed Scanning... before the three-second Git delay completed
  • waited for the clean result and exercised the compact report
  • opened copy context and the GitHub Actions confirmation, then cancelled safely

Download the edited MP4 and PNG evidence

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant