Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 20, 2026 08:28
aidenybai
marked this pull request as draft
October 21, 2026 15:05
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
aidenybai
marked this pull request as ready for review
October 21, 2026 15:45
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A directly imported helper can assign a browser cookie inside a state updater. React may replay that updater, but the existing call classification missed the imported write.
What changed
Certify the bounded readonly exported arrow and its single cookie assignment with supported string data. Independent review closed dynamic provider replacement and CommonJS export replacement paths, preserved erased TypeScript name handling, and declined ambient or unsupported runtime providers. The caller and foreign module retain separate export-closure requirements.
Added focused provider controls, synthetic fuzz regressions, generator controls, and patch Changesets for published behavior. Existing author fixture and snippet literal values and order remain intact.
Validation
.ctsexport-replacement controls changed two false warnings to zero. Isolated VM checks using replaceable custom JavaScript globals confirmed that these exported helpers did not call the controlled cookie setter; a nominal helper still called it. These checks do not exercise replacement of native Window.document, a browser, or React mounting.Remote parity is blocked by missing Vercel Sandbox authentication, team/org, and project environment variables. No remote corpus or performance result is claimed.
Shared diagnostic evidence performance repair
Merged shared lazy evidence commit
adcd927. The cookie detector is unchanged relative to reviewed head9e33830; raw UTF-8 byte spans, CRLF handling, fingerprints, options and filesystem failure behavior remain covered. TypeScript AST construction is deferred until forwarded-handler evidence needs it.All nine new local validation commands passed: fresh five-package build, 62 focused evidence/cache tests, full workspace tests, lint, typecheck, format, generation, rebuilt packages and JSON smoke. The strict intermediate artifact audit remains failed for the independently reviewed one-line
DeadCodeOverlapdeclaration union ordering; all other 174 artifacts and JavaScript matched, and the final build restored the bootstrap map. The clean committed fresh build has 175 verified artifacts and five owned runtime edges, including the actual CLI bootstrap, in both the worktree and archive.Finite CLI comparisons cover all nine corrected cookie-provider graphs, the valid alias graph, and General128. All 368 reports preserve complete selected-file coverage, full diagnostic objects and five-field framework context. Three positive graphs retain one cookie warning each; seven controls retain zero. General128 retains 256 full objects across 11 files. The original misplaced extraction graphs remain quarantined.
All 22 cold/hot comparisons qualified as measured and stable under the repository's material-change threshold, with no CPU +10% or RSS +20% review flags. Corrected case 1 cold median is 415.141→337.122 ms (CPU 0.67→0.57 s); case 3 is 421.547→330.723 ms (CPU 0.68→0.57 s). Signed fluctuations in quiet controls remain recorded. Dedicated captures retain all 39,681 CPU samples with no nonpositive offsets; cold primary rows are available in both revisions of all ten target graphs. Hot primary rows are unavailable, so attribution stays partial. These are finite local observations, not a universal performance guarantee.
Hosted parity and RDE were not run because the required credentials are unavailable. Exact-head CI and a new natural ready-for-review React Doctor run are tracked separately.