Repository navigation
Conversation
commit: |
aidenybai
marked this pull request as ready for review
October 17, 2026 01:52
aidenybai
marked this pull request as draft
October 17, 2026 02:16
aidenybai
marked this pull request as ready for review
October 17, 2026 02:56
aidenybai
marked this pull request as draft
October 17, 2026 03:02
aidenybai
marked this pull request as ready for review
October 17, 2026 03:43
aidenybai
marked this pull request as draft
October 17, 2026 04:05
aidenybai
marked this pull request as ready for review
October 17, 2026 05:02
This was referenced Oct 22, 2026
aidenybai
marked this pull request as draft
October 22, 2026 11:00
aidenybai
marked this pull request as ready for review
October 22, 2026 11:57
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A child may expose live state through a getter that the parent consumes in a template result. Treating that read as a bare state notification produces a false positive from
no-pass-live-state-to-parent.What changed
1f7953c59095b1a43bbc0b0ca2a5854ac0eda690through a normal merge, including its shared provider-proof and numeric-data performance repairs.React.useCallbackdispatch shapes remain outside this exemption.Validation
Head:
898e6d3c6496f94a83b22f0956ce40419a950197.All local gates passed: prepare, full uncached test run, lint, uncached typecheck, format, generated registry, fresh five-package build, JSON report smoke, and target-rule strict fuzzing (500 configured iterations, seed 42, required target firing). Normal commit hooks passed; committed source and all 175 runtime files match the validated tree.
The shared cache has direct regression tests for query modes, call shape, initializer ordering and fresh analyses. Disabling either cache layer fails its work-growth regression test.
Remote parity was not run because the required Daytona credentials are unavailable; a local RDE checkout is also unavailable.
Local evidence:
tmp/fpfn-regression-profile-2026-10-20/continue-20261022/stack-drift-review-v1/pr-1994-validation-v2/proof.jsonandpr-1994-normal-merge-commit-v1/proof.jsonin that directory.Completed performance and regression review
Exact target and fixed general full-engine comparisons passed. Each workload includes activation plus five cold and five hot timing samples per revision and dedicated CPU captures; raw gzip artifacts and timing rows were independently read back. All four wall cohorts are stable under the fixed 10% plus 250 ms budget; total CPU and RSS manual flags are clear. Every complete unrelated diagnostic and all five project-context fields match. The general workload retains all 256 diagnostics. These are finite local measurements.
Target-specific evidence: the current-parent integration preserves every complete diagnostic from the externally updated getter head.
All available exact-head checks are green, including the natural react-doctor run started after marking this PR ready. The live stacked base and main were rechecked. This PR is ready for review; merge the stacked parent first.
CPU sampling limit
One retained dedicated CPU profile contains one signed −1 µs sampling delta. CPU attribution is incomplete at those exact samples; the original raw profiles remain unchanged. Separate measured wall time, process CPU and RSS rows were independently recomputed and stay within the declared finite budgets. This qualification does not extend to other malformed samples or universal performance guarantees.