Repository navigation
[CI] Remove unused Rust setup from lint workflows - #33613
Merged
Tianlei Wu (tianleiwu) merged 2 commits intoOct 26, 2026
Merged
Tianlei Wu (tianleiwu) merged 2 commits into
Tianlei Wu (tianleiwu) merged 2 commits into
Conversation
The lint job runs Ruff and clang-format from Python wheels and does not use rustfmt. Remove the unnecessary Rust bootstrap and moving stable download dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep PR Checks aligned with the Python format job: both run prebuilt lintrunner, Ruff, and clang-format packages without using rustfmt. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
eserscor
marked this pull request as ready for review
October 26, 2026 13:15
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow deletions remove an unused dependency without changing downstream lint behavior, and no actionable issues were identified.
No open issues 🎉
What changed in this PR
Removes unused Rust setup from ONNX Runtime’s two lint workflows, eliminating a bootstrap dependency that caused intermittent failures.
Changes:
- Removes Rust toolchain and
rustfmtinstallation from both lint jobs. - Leaves lint rules, formatting suggestions, and SARIF handling unchanged.
| File | Description |
|---|---|
.github/workflows/pr_checks.yml |
Removes Rust setup from the Suggest fixes job. |
.github/workflows/lint.yml |
Removes Rust setup from the Python format job. |
Review effort: Balanced
Tianlei Wu (tianleiwu)
approved these changes
Oct 26, 2026
Tianlei Wu (tianleiwu)
deleted the
eserscor-dev/erscor/2026/10/26-remove-unused-rust
branch
October 26, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the unused
Setup Ruststep from both lint workflows:Python formatin.github/workflows/lint.yml.Suggest fixesin.github/workflows/pr_checks.yml.The configured linters are RUFF, RUFF-FORMAT, and CLANGFORMAT; their Python packages provide prebuilt wheels, and none invokes rustfmt. No lint rules, suggestion behavior, or SARIF handling are changed.
Validation:
actionlint.exe -config-file <temporary-config> -shellcheck= -pyflakes= .github\workflows\lint.yml .github\workflows\pr_checks.yml— passed with actionlint 1.7.12. The temporary configuration declares the existing custom runner label; optional ShellCheck/Pyflakes integrations were disabled.rustup,rustc,rustfmt, andcargounavailable on PATH.lintrunner initpassed.lintrunner --force-color --all-files --tee-json=lint.json -vfollowed bypython -m lintrunner_adapters to-sarif lint.json lintrunner.sarif— formatting-error and non-formatting Ruff-error fixtures correctly returned lint exit 1 and produced valid nonempty SARIF; clean files returned lint exit 0 and valid empty SARIF.set +e; lintrunner f --all-files -v; exit 0— passed on formatting-error and clean fixtures. The error fixture was correctly formatted, and both runs returned exit 0 without Rust.git diff --check— passed.Local fixture tests are not a full repository lint run. An isolated intentional-formatting-failure branch is being exercised separately as an automation negative control; its fixture is not included in this PR.
Motivation and Context
Both workflows share the same unnecessary Rust bootstrap and moving
stablechannel dependency. Six observedLint / Python formatruns failed during Rust setup and passed on retry at the identical merge commit. Failed attempts stopped in bootstrap-download retries before lintrunner ran; successful retries reportedNo lint issues. The PR Checks investigation independently found the same mechanism.Representative failed attempt and successful retry. The missing
lintrunner.sarifwas secondary: dependency installation was skipped after Rust setup failed. Removing the unused toolchain eliminates that dependency rather than caching a tool neither workflow consumes.