Repository navigation
Conversation
The lint job runs Ruff and clang-format from Python wheels and does not use rustfmt. Remove the unnecessary Rust bootstrap and moving stable download dependency. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Intentionally retain single quotes so RUFF-FORMAT fails for automation validation. Remove this fixture after the experiment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
| @@ -0,0 +1,3 @@ | |||
| """Temporary lint CI negative control; remove after automation validation.""" | |||
Base automatically changed from
eserscor-dev/erscor/2026/10/26-remove-unused-rust
to
main
October 26, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TEMPORARY NEGATIVE CONTROL / DO NOT MERGE. This draft PR intentionally fails
RUFF-FORMATto validate the Python format GitHub Actions failure path and subsequent SARIF production/upload. It is stacked on #33613, not intended formainor production.The only change is
tools/ci_build/lint_failure_validation.py: valid Python with a deliberately single-quoted dictionary on line 3. The fixture is explicitly temporary and must remain unformatted during this experiment. No lint rules or workflow execution are changed. Parent #33613 remains untouched.Local validation on Windows with repository-pinned lintrunner 0.13.1, lintrunner-adapters 0.14.1, and ruff 0.12.12:
python -m pip install --quiet -r requirements-lintrunner.txtin an isolated virtual environment: passed.lintrunner init: passed.$artifactsset to this session's external artifact directory,lintrunner --force-color --tee-json="$artifacts\lint-negative-control.json" -v tools\ci_build\lint_failure_validation.py: expected failure, exit 1, exactly oneRUFF-FORMAT/formatdiagnostic on the fixture; noRUFFcheck findings.python -m lintrunner_adapters to-sarif "$artifacts\lint-negative-control.json" "$artifacts\lint-negative-control.sarif": passed, exit 0.git diff --cached --check: passed before commit.Generated lint JSON, SARIF, and schema files are outside the repository and are not committed. A full-repository local lint run was not performed; this PR exercises the existing automatic
--all-filesCI run. Expected CI outcomes:Run lintrunner on all filesfails on this fixture, whileProduce SARIFandUpload SARIF filesucceed. No manual dispatch or redundant rerun is requested.Motivation and Context
User-approved negative-control experiment for #33613, which removes unused Rust setup from the Python format workflow. Verify that removing Rust setup preserves both real lint failures and SARIF reporting, rather than producing a provisioning failure. This draft PR is only a validation vehicle; do not merge it or fix the intentional formatting violation as part of this experiment.