Repository navigation
Creating importers for the new SQL Log Scout Connectivity Related collector - #560
Merged
JosephPilov-MSFT (PiJoCoder) merged 2 commits intoSep 15, 2026
Conversation
Collaborator
|
Tested an import and I got schema for all these tables (some of them were empty due to empty source data) use sqlnexus
go
select * from tbl_tls_ssl_protocols
select * from tbl_sql_client_drivers
select * from tbl_sql_spn_service_accounts
select * from tbl_sql_spn_registered
select * from tbl_sql_spn_suggested
select * from tbl_sql_service_summary
select * from tbl_sql_service_account_delegation
select * from tbl_kerberos_local_policy
select * from tbl_sql_instance_network_security
select * from tbl_sql_client_aliases
select * from tbl_sql_server_certificates
select * from tbl_sql_server_certificate_key_acl |
JosephPilov-MSFT (PiJoCoder)
approved these changes
Sep 15, 2026
JosephPilov-MSFT (PiJoCoder)
deleted the
ansavio_newconnectivityimporters_logscout
branch
September 15, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for importing and testing a new set of SQL LogScout connectivity and security collector rowsets. These rowsets cover TLS protocols, SQL client drivers, SPNs, service accounts, client aliases, and server certificates, and are now defined in both
TextRowsets.xmlfiles. Additionally, new regression tests ensure the import engine correctly parses these fixed-width, sqlcmd-style outputs, especially for edge cases like wide trailing columns and renamed headers.The following tables have been created
select * from [tbl_tls_ssl_protocols]
select * from [tbl_sql_client_drivers]
select * from [tbl_sql_spn_service_accounts]
select * from [tbl_sql_spn_registered]
select * from [tbl_sql_spn_suggested]
select * from [tbl_sql_service_summary]
select * from [tbl_sql_service_account_delegation]
select * from [tbl_kerberos_local_policy]
select * from [tbl_sql_instance_network_security]
select * from [tbl_sql_client_aliases]
select * from [tbl_sql_server_certificates]
select * from [tbl_sql_server_certificate_key_acl]
Rowset Definitions and Import Support:
RowsetImportEngine/TextRowsets.xmlandsqlnexus/TextRowsets.xml. These include rowsets for TLS/SSL protocols, SQL client drivers, SPN service accounts and registrations, service summaries, Kerberos policy, client aliases, server certificates, and related key ACLs. Each rowset specifies known columns and their types/widths to support fixed-width import.Testing and Validation:
ConnectivityCollectorRowsetTestsinConnectivityCollectorRowsetTests.csto provide regression coverage for these rowsets. The tests verify that:Pathfield in client drivers) are fully captured, preventing silent truncation.ServiceAccountNameinstead ofStartName) are correctly recognized and parsed.