Repository navigation
Fix RelateNG strategy for avoiding self-noding - #1259
Merged
Merged
Conversation
This was referenced Nov 17, 2026
dbaston
added a commit
to libgeos/geos
that referenced
this pull request
Nov 20, 2026
Based on locationtech/jts#1259 and locationtech/jts#1260 Fixes #1558 Fixes #1595 Fixes #1597 Co-authored-by: Martin Davis <mtnclimb@gmail.com>
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Nov 20, 2026
Based on locationtech/jts#1259 and locationtech/jts#1260 Fixes libgeos#1558 Fixes libgeos#1595 Fixes libgeos#1597 Co-authored-by: Martin Davis <mtnclimb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
RelateNGoptimization strategy to avoid the need for self-noding in specific cases was not strict enough, and did not correctly evaluate deeply-nested collections. This fix tightens the criteria for which geometries do not need self-noding (in particular, only polygonal geometries with no holes). It also ensures the self-noding check is applied equally to both input geometries.Reported in: