Repository navigation
Fix RelateNG self-noding check for MultiPolygons - #1260
Merged
dr-jts merged 1 commit intoNov 18, 2026
Merged
Conversation
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Nov 19, 2026
Based on locationtech/jts#1260 Co-authored-by: Martin Davis <mtnclimb@gmail.com>
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Nov 19, 2026
Based on locationtech/jts#1260 Co-authored-by: Martin Davis <mtnclimb@gmail.com>
dbaston
added a commit
to libgeos/geos
that referenced
this pull request
Nov 20, 2026
Based on locationtech/jts#1259 and locationtech/jts#1260 Fixes #1558 Fixes #1595 Fixes #1597 Co-authored-by: Martin Davis <mtnclimb@gmail.com>
dbaston
added a commit
to dbaston/libgeos
that referenced
this pull request
Nov 20, 2026
Based on locationtech/jts#1259 and locationtech/jts#1260 Fixes libgeos#1558 Fixes libgeos#1595 Fixes libgeos#1597 Co-authored-by: Martin Davis <mtnclimb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix further tightens the RelateNG self-noding strategy from the work in #1259. It is not safe to avoid self-noding MultiPolygons with two or more elements, since they may touch at a vertex and an edge. This causes the same issue with building topology at the implcit node as in libgeos/geos#1558.
A MultiPolygon with a vertex that touches a Polygon along an edge
