Skip to content

Run the concurrent first produce checks on JRuby #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mensfeld merged 1 commit into from
Oct 31, 2026
Merged

Run the concurrent first produce checks on JRuby #1083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions spec/integrations/producer_concurrent_first_produce_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,6 @@
closer = Thread.new { producer.close }

unless closer.join(CLOSE_TIMEOUT)
# On JRuby concurrent produces can leave the operations counter of the native client
# unbalanced, so `close` waits forever until
# https://github.com/karafka/rdkafka-ruby/pull/1055 is merged. Remove this branch with it.
# `exit!` skips the `at_exit` close that would wait the same way.
if defined?(JRUBY_VERSION)
puts "SKIP: close did not finish on JRuby, handle destruction not checked"
exit!(0)
end

warn "FAIL: close did not finish in #{CLOSE_TIMEOUT} s"
exit!(1)
end
Expand Down
6 changes: 0 additions & 6 deletions spec/lib/rdkafka/producer_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,12 +1397,6 @@ def call(_, handle)
after { recording[:active] = false }

it "creates exactly one topic handle per topic and destroys each on close" do
# Concurrent produces leave the operations counter unbalanced on JRuby, so `close` hangs
# until https://github.com/karafka/rdkafka-ruby/pull/1055 is merged. Remove this skip with
# it. Until then
# `spec/integrations/producer_concurrent_first_produce_spec.rb` covers JRuby.
skip "Producer#close can hang after concurrent produces on JRuby" if defined?(JRUBY_VERSION)

start = Queue.new
errors = Queue.new

Expand Down
Loading