Repository navigation
Run the concurrent first produce checks on JRuby - #1083
Merged
Merged
Conversation
mensfeld
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redmine: 49686
Removes the two JRuby skips added in #1056 that waited for #1055 (now merged):
spec/lib/rdkafka/producer_spec.rb: rspecskipon the concurrent first produce examplespec/integrations/producer_concurrent_first_produce_spec.rb: JRubySKIPbranch whenclosetimed outSpec-only. No
lib/change, no CHANGELOG.Verification
Local, broker from
docker-compose.yml, 3 runs each:spec/integrations/producer_concurrent_first_produce_spec.rbPASS3/3 (incl. handle destruction afterclose);spec/lib/rdkafka/producer_spec.rb109 examples, 0 failures, 3/3PASS3/3 (incl. handle destruction afterclose);producer_spec.rb109 examples, 0 failures, 2 pending (the fork examples), 3/3. The formerly skipped example runs and passes.Performance impact
none (spec-only)