Conversation
commit: |
✅ Testplane E2E run succeed
|
✅ Testplane browser-env run succeed
|
|
|
||
| this._fail(); | ||
|
|
||
| signalHandler.emit(MasterEvents.EXIT, err); |
There was a problem hiding this comment.
Need for send event to reporter
shadowusr
left a comment
shadowusr
left a comment
There was a problem hiding this comment.
I'd wait with this one until issues in gemini-testing/html-reporter#800 are resolved.
57ee3ab to
974af3d
Compare
| @@ -0,0 +1,15 @@ | |||
| export const formatError = (err: Error): Error => { | |||
| const TRIM_MARKERS = ["Tests were stopped by the user"]; | |||
There was a problem hiding this comment.
Remove stack for some errors, now only for force stop
| super(stateName, currImg, refImg); | ||
|
|
||
| this.message = `can not find reference image at ${this.refImg.path} for "${stateName}" state`; | ||
| this.stack = undefined; |
There was a problem hiding this comment.
Remove stack for no ref image error
There was a problem hiding this comment.
imho error formatting should happen on reporter's side, not on the source side. This affects both this error and tests were stopped by user error. But that's not critical. Just more clean in my opinion — the source should give full info, the receiver should filter what's needed.
There was a problem hiding this comment.
Now realized on reporter side, also for 429 and no ref image errors
b26bdb3 to
f85b4e4
Compare
2 participants
Add exit for test when halt and also add pass error to test in this case.