Feat stop tests button

[sonic16x]

Now user can stop all test after run using stop button which appear after click to start button.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/html-reporter@800

commit: 6f1f451

[github-actions]

✅ Component tests succeed

Report

[github-actions]

✅ E2E tests succeed

Report

[shadowusr]

We have a conflict, like 20 lines above — S is already used for Suites page.

[sonic16x]

Now shitf+s, but maybe just x ?

[shadowusr]

Browsers are not closed reliably on stop, I reproduced this multiple times, when after stopping, the browsers are left hanging:

[shadowusr]

It doesn't seem to work right with multiple retries configured in UI. I tested it together with these changes: gemini-testing/testplane#1318

And yet, after clicking the stop button, it will stop only the current retry and not subsequent ones.

[shadowusr]

IMO this looks pretty ugly:

It would be really nice if we didn't show any error at all in this case, but instead clearly stated in status "Interrupted" and for example had gray icon and gray retry selector background (not red).

This is not absolutely critical, but would be very nice to have.

[shadowusr]

As for the button on the right: I think we should be able to stop tests from there. We should just clearly state "Stop all" if stopping individual test is currently hard to implement. I would imagine that upon clicking on "Retry" button it would be replaced with "Stop All" button, that doesn't have arrow down with options on the right and has the exact same size to avoid UI jumps

[shadowusr]

I think e2e test on this is a must. Especially considering that it would be very easy to set it up: we already have GUI tests, so any LLM would easily generate this one.

[sonic16x]

Maybe red background? But I'm not sure

[shadowusr]

It works much better now, but still occasionally leaves opened browsers behind (but that's rare and not critical). When stopping tests that are waiting for session from a remote grid, i get these errors:

CancelledError
CancelledError: Browser request was cancelled

What happened:
- This test tried to run in a browser that was already stopped
- This likely happened due to a critical error, like an unhandled promise rejection
What you can do:
- Check other failed tests or execution logs for more details, usually you can find the root cause there
    at BasicPool.getBrowser (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/browser-pool/basic-pool.js:79:23)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async LimitedPool.getBrowser (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/browser-pool/limited-pool.js:37:20)
    at async BrowserAgent.getBrowser (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/runner/browser-agent.js:13:25)
    at async RegularTestRunner._getBrowser (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/runner/test-runner/regular-test-runner.js:155:29)
    at async RegularTestRunner._run (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/runner/test-runner/regular-test-runner.js:47:29)
    at async InsistantTestRunner.run (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/runner/test-runner/insistant-test-runner.js:38:9)
    at async BrowserRunner._runTest (/Users/shadowusr/dev/testplane/wt/fix-testplane-9-on-old-browsers/build/src/runner/browser-runner.js:102:9)

Instead of clean interrupted by user error. I think this would be a frequent case for sessions that take a while to start, for example, android sessions. So it would be nice to be fixed.

Also, I think it would be very important to check how it works with remote grid in this case: will those sessions be left hanging or will they be correctly stopped?