Skip to content

fix: Added changes in the policy_comments API to include creator details #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sumitkumarsage wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Added changes in the policy_comments API to include creator details #892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
428bd60
Added changes as per the changes in the policy_comments API
sumitkumarsage Sep 9, 2026
01b79bc
Auto generate API docs
sumitkumarsage Sep 9, 2026
704e853
Update policy comment response documentation
sumitkumarsage Sep 10, 2026
6d93a8c
Merge remote-tracking branch 'origin/main' into update_expense_commen…
sumitkumarsage Sep 10, 2026
02db408
Auto generate API docs
sumitkumarsage Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 58 additions & 10 deletions reference/admin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16027,14 +16027,7 @@ paths:
expense_policy_comments:
type: array
items:
type: object
properties:
comment_type:
type: string
description: The comment type
comment_text:
type: string
description: The comment text
$ref: '#/components/schemas/expense_policy_comment_out'
required:
- expense_id
- expense_policy_comments
Expand All @@ -16043,8 +16036,18 @@ paths:
data:
expense_id: txGCcvnhUbrP
expense_policy_comments:
- comment_type: MISSING_FIELDS
comment_text: Reason for missing fields
- id: epc1a2f3farmk
expense_id: txGCcvnhUbrP
org_id: orGCcvnhUbrP
comment_type: POLICY_VIOLATION_REASON
comment_text: This expense was required for a client meeting
created_at: '2026-09-08T06:30:00.000Z'
updated_at: '2026-09-08T06:30:00.000Z'
creator_user_id: usRahul123
creator_user:
id: usRahul123
email: rahul@example.com
full_name: Rahul
'400':
description: Unauthorised request
content:
Expand Down Expand Up @@ -21194,6 +21197,8 @@ components:
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
Expand All @@ -21212,6 +21217,10 @@ components:
$ref: '#/components/schemas/created_at'
updated_at:
$ref: '#/components/schemas/updated_at'
creator_user_id:
$ref: '#/components/schemas/user_id'
creator_user:
$ref: '#/components/schemas/user_out_embed'
expense_verification_out_embed:
type: object
additionalProperties: false
Expand Down Expand Up @@ -40590,6 +40599,45 @@ components:
$ref: '#/components/schemas/id_string'
description: ID of the advance request to be approved
example: areq5F9xIaMURI
expense_policy_comment_out:
type: object
additionalProperties: false
required:
- id
- expense_id
- org_id
- comment_type
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
- $ref: '#/components/schemas/id_string'
example: epc1a2f3farmk
expense_id:
$ref: '#/components/schemas/id_string'
org_id:
$ref: '#/components/schemas/org_id'
comment_type:
type: string
enum:
- LOST_RECEIPT_REASON
- POLICY_VIOLATION_REASON
description: Type of the policy comment
comment_text:
type: string
description: Text content of the policy comment
created_at:
$ref: '#/components/schemas/created_at'
updated_at:
$ref: '#/components/schemas/updated_at'
creator_user_id:
$ref: '#/components/schemas/user_id'
creator_user:
$ref: '#/components/schemas/user_out_embed'
advance_request_add_approver_in:
type: object
additionalProperties: false
Expand Down
6 changes: 6 additions & 0 deletions reference/approver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6022,6 +6022,8 @@ components:
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
Expand All @@ -6040,6 +6042,10 @@ components:
$ref: '#/components/schemas/created_at'
updated_at:
$ref: '#/components/schemas/updated_at'
creator_user_id:
$ref: '#/components/schemas/user_id'
creator_user:
$ref: '#/components/schemas/user_out_embed'
expense_verification_out_embed:
type: object
additionalProperties: false
Expand Down
6 changes: 6 additions & 0 deletions reference/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2487,6 +2487,8 @@ components:
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
Expand All @@ -2505,6 +2507,10 @@ components:
$ref: '#/components/schemas/created_at'
updated_at:
$ref: '#/components/schemas/updated_at'
creator_user_id:
$ref: '#/components/schemas/user_id'
creator_user:
$ref: '#/components/schemas/user_out_embed'
expense_verification_out_embed:
type: object
additionalProperties: false
Expand Down
68 changes: 58 additions & 10 deletions reference/spender.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6657,14 +6657,7 @@ paths:
expense_policy_comments:
type: array
items:
type: object
properties:
comment_type:
type: string
description: The comment type
comment_text:
type: string
description: The comment text
$ref: '#/components/schemas/expense_policy_comment_out'
required:
- expense_id
- expense_policy_comments
Expand All @@ -6673,8 +6666,18 @@ paths:
data:
expense_id: txGCcvnhUbrP
expense_policy_comments:
- comment_type: MISSING_FIELDS
comment_text: Reason for missing fields
- id: epc1a2f3farmk
expense_id: txGCcvnhUbrP
org_id: orGCcvnhUbrP
comment_type: POLICY_VIOLATION_REASON
comment_text: This expense was required for a client meeting
created_at: '2026-09-08T06:30:00.000Z'
updated_at: '2026-09-08T06:30:00.000Z'
creator_user_id: usRahul123
creator_user:
id: usRahul123
email: rahul@example.com
full_name: Rahul
'400':
description: Unauthorised request
content:
Expand Down Expand Up @@ -9593,6 +9596,8 @@ components:
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
Expand All @@ -9611,6 +9616,10 @@ components:
$ref: '#/components/schemas/created_at'
updated_at:
$ref: '#/components/schemas/updated_at'
creator_user_id:
$ref: '#/components/schemas/user_id'
creator_user:
$ref: '#/components/schemas/user_out_embed'
expense_verification_out_embed:
type: object
additionalProperties: false
Expand Down Expand Up @@ -22716,6 +22725,45 @@ components:
anyOf:
- $ref: '#/components/schemas/org_settings_fyler_ccc_flow_settings_out'
- $ref: '#/components/schemas/org_settings_null_out'
expense_policy_comment_out:
type: object
additionalProperties: false
required:
- id
- expense_id
- org_id
- comment_type
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
- $ref: '#/components/schemas/id_string'
example: epc1a2f3farmk
expense_id:
$ref: '#/components/schemas/id_string'
org_id:
$ref: '#/components/schemas/org_id'
comment_type:
type: string
enum:
- LOST_RECEIPT_REASON
- POLICY_VIOLATION_REASON
description: Type of the policy comment
comment_text:
type: string
description: Text content of the policy comment
created_at:
$ref: '#/components/schemas/created_at'
updated_at:
$ref: '#/components/schemas/updated_at'
creator_user_id:
$ref: '#/components/schemas/user_id'
creator_user:
$ref: '#/components/schemas/user_out_embed'
advance_request_submit_in:
allOf:
- $ref: '#/components/schemas/advance_request_in_base'
Expand Down
23 changes: 13 additions & 10 deletions src/admin/paths/admin@expense_policy_comments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,7 @@ post:
expense_policy_comments:
type: array
items:
type: object
properties:
comment_type:
type: string
description: The comment type
comment_text:
type: string
description: The comment text
$ref: '../../components/schemas/expense.yaml#/expense_policy_comment_out'
required:
- expense_id
- expense_policy_comments
Expand All @@ -87,8 +80,18 @@ post:
data:
expense_id: "txGCcvnhUbrP"
expense_policy_comments:
- comment_type: "MISSING_FIELDS"
comment_text: "Reason for missing fields"
- id: "epc1a2f3farmk"
expense_id: "txGCcvnhUbrP"
org_id: "orGCcvnhUbrP"
comment_type: "POLICY_VIOLATION_REASON"
comment_text: "This expense was required for a client meeting"
created_at: "2026-09-08T06:30:00.000Z"
updated_at: "2026-09-08T06:30:00.000Z"
creator_user_id: "usRahul123"
creator_user:
id: "usRahul123"
email: "rahul@example.com"
full_name: "Rahul"
'401':
description: Unauthorised request
content:
Expand Down
48 changes: 47 additions & 1 deletion src/components/schemas/expense.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3124,6 +3124,8 @@ expense_policy_comment_out_embed:
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
Expand All @@ -3141,4 +3143,48 @@ expense_policy_comment_out_embed:
created_at:
$ref: './fields.yaml#/created_at'
updated_at:
$ref: './fields.yaml#/updated_at'
$ref: './fields.yaml#/updated_at'
creator_user_id:
$ref: './fields.yaml#/user_id'
creator_user:
$ref: './user.yaml#/user_out_embed'

expense_policy_comment_out:
type: object
additionalProperties: false
required:
- id
- expense_id
- org_id
- comment_type
- comment_text
- created_at
- updated_at
- creator_user_id
- creator_user
properties:
id:
allOf:
- $ref: './fields.yaml#/id_string'
example: epc1a2f3farmk
expense_id:
$ref: './fields.yaml#/id_string'
org_id:
$ref: './fields.yaml#/org_id'
comment_type:
type: string
enum:
- LOST_RECEIPT_REASON
- POLICY_VIOLATION_REASON
description: Type of the policy comment
comment_text:
type: string
description: Text content of the policy comment
created_at:
$ref: './fields.yaml#/created_at'
updated_at:
$ref: './fields.yaml#/updated_at'
creator_user_id:
$ref: './fields.yaml#/user_id'
creator_user:
$ref: './user.yaml#/user_out_embed'
23 changes: 13 additions & 10 deletions src/spender/paths/spender@expense_policy_comments.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,7 @@ post:
expense_policy_comments:
type: array
items:
type: object
properties:
comment_type:
type: string
description: The comment type
comment_text:
type: string
description: The comment text
$ref: '../../components/schemas/expense.yaml#/expense_policy_comment_out'
required:
- expense_id
- expense_policy_comments
Expand All @@ -87,8 +80,18 @@ post:
data:
expense_id: "txGCcvnhUbrP"
expense_policy_comments:
- comment_type: "MISSING_FIELDS"
comment_text: "Reason for missing fields"
- id: "epc1a2f3farmk"
expense_id: "txGCcvnhUbrP"
org_id: "orGCcvnhUbrP"
comment_type: "POLICY_VIOLATION_REASON"
comment_text: "This expense was required for a client meeting"
created_at: "2026-09-08T06:30:00.000Z"
updated_at: "2026-09-08T06:30:00.000Z"
creator_user_id: "usRahul123"
creator_user:
id: "usRahul123"
email: "rahul@example.com"
full_name: "Rahul"
'401':
description: Unauthorised request
content:
Expand Down
Loading