fix: Added changes in the policy_comments API to include creator details - #892
Open
sumitkumarsage wants to merge 5 commits into
Open
fix: Added changes in the policy_comments API to include creator details#892sumitkumarsage wants to merge 5 commits into
sumitkumarsage wants to merge 5 commits into
Conversation
|
PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive) |
|
PR title must start with "fix:", "feat:", "chore:", "refactor", or "test:" (case-insensitive) |
sumitkumarsage
changed the title
…ts_api_response # Conflicts: # reference/admin.yaml # reference/spender.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated /{admin|spender}/expense_policy_comments API response to include creator details
Updated GET /{role}/expenses API :
`
{
"count": 10000,
"offset": 10,
"data": [
{
"id": "txwownwrng",
"user_id": "uswjwgnwwgo",
"user": {
"id": "uswjwgnwwgo",
"email": "john.doe@example.com",
"full_name": "John Doe"
},
"org_id": "orwruogwnngg",
.....,
"expense_policy_comments": [
{
"id": "epc1a2f3farmk",
"comment_type": "LOST_RECEIPT_REASON",
"comment_text": "string",
"created_at": "2020-06-01T13:14:54.804+00:00",
"updated_at": "2020-06-11T13:14:55.201598+00:00",
"creator_user_id": "uswjwgnwwgo",
"creator_user": {
"id": "uswjwgnwwgo",
"email": "john.doe@example.com",
"full_name": "John Doe"
}
}
]
}
]
}
`
Clickup
https://app.clickup.com/