Skip to content

Version Attributes changed from optional to mandatory #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anmittag wants to merge 1 commit into from
Closed

Version Attributes changed from optional to mandatory #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/extensions/score_metamodel/metamodel.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# *******************************************************************************
# Copyright (c) 2025 Contributors to the Eclipse Foundation
# Copyright (c) 2026 Contributors to the Eclipse Foundation
#
# See the NOTICE file(s) distributed with this work for additional
# information regarding copyright ownership.
Expand All @@ -13,12 +13,10 @@
# yaml-language-server: $schema=./metamodel-schema.json

needs_types_base_options:
optional_options:
mandatory_options:

@MaximilianSoerenPollak MaximilianSoerenPollak Jul 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you SURE that this is what you want to achieve?
This change will make source_code_links, testlinks and versions mandatory, not just versions.

If you want to do just versions (which is probably what you mean) then you can do so roughly like this:

needs_types_base_options:
  mandatory_options:
     # req-Id: tool_req__docs_common_attr_version
     version: ^[0-9]*$
   optional_options:
      # req-Id: tool_req__docs_dd_link_source_code_link
     source_code_link: ^https://github.com/.*
     testlink: ^https://github.com/.*

# req-Id: tool_req__docs_dd_link_source_code_link
source_code_link: ^https://github.com/.*
testlink: ^https://github.com/.*
# Version will be mandatory global option in future releases
# For now giving grace periods to consumers
# req-Id: tool_req__docs_common_attr_version
version: ^[0-9]*$

Expand Down
Loading