Version Attributes changed from optional to mandatory#630
Open
anmittag wants to merge 1 commit into
Open
Conversation
Updated copyright year from 2025 to 2026 and changed optional_options to mandatory_options. Signed-off-by: AndreasMittag <andreas.mittag@etas.com>
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
MaximilianSoerenPollak
requested changes
Jul 6, 2026
MaximilianSoerenPollak
left a comment
Contributor
There was a problem hiding this comment.
Do you want all 3 attributes to be mandatory or just the version?
|
|
||
| needs_types_base_options: | ||
| optional_options: | ||
| mandatory_options: |
Contributor
There was a problem hiding this comment.
Are you SURE that this is what you want to achieve?
This change will make source_code_links, testlinks and versions mandatory, not just versions.
If you want to do just versions (which is probably what you mean) then you can do so roughly like this:
needs_types_base_options:
mandatory_options:
# req-Id: tool_req__docs_common_attr_version
version: ^[0-9]*$
optional_options:
# req-Id: tool_req__docs_dd_link_source_code_link
source_code_link: ^https://github.com/.*
testlink: ^https://github.com/.*
Contributor
|
@anmittag Do you want me to implement the change that version attributes are now mandatory? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated copyright year from 2025 to 2026 and changed optional_options to mandatory_options.
📌 Description
Versions Attribute is changed from optional to mandatory based on issue eclipse-score/infrastructure#29
🚨 Impact Analysis
✅ Checklist