Skip to content

Version Attributes changed from optional to mandatory#630

Open
anmittag wants to merge 1 commit into
eclipse-score:mainfrom
etas-contrib:ver_attr_mandatory
Open

Version Attributes changed from optional to mandatory#630
anmittag wants to merge 1 commit into
eclipse-score:mainfrom
etas-contrib:ver_attr_mandatory

Conversation

@anmittag

@anmittag anmittag commented Jul 3, 2026

Copy link
Copy Markdown
Member

Updated copyright year from 2025 to 2026 and changed optional_options to mandatory_options.

📌 Description

Versions Attribute is changed from optional to mandatory based on issue eclipse-score/infrastructure#29

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

Updated copyright year from 2025 to 2026 and changed optional_options to mandatory_options.

Signed-off-by: AndreasMittag <andreas.mittag@etas.com>
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: c62d171e-c6d7-4206-ba7c-a328c29f36f4
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 6.368s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@anmittag anmittag changed the title Update copyright year and change options to mandatory Version Attributes changed from optional to mandatory Jul 3, 2026
@anmittag anmittag marked this pull request as ready for review July 3, 2026 15:47

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want all 3 attributes to be mandatory or just the version?


needs_types_base_options:
optional_options:
mandatory_options:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you SURE that this is what you want to achieve?
This change will make source_code_links, testlinks and versions mandatory, not just versions.

If you want to do just versions (which is probably what you mean) then you can do so roughly like this:

needs_types_base_options:
  mandatory_options:
     # req-Id: tool_req__docs_common_attr_version
     version: ^[0-9]*$
   optional_options:
      # req-Id: tool_req__docs_dd_link_source_code_link
     source_code_link: ^https://github.com/.*
     testlink: ^https://github.com/.*

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

@anmittag Do you want me to implement the change that version attributes are now mandatory?
Or will you amend this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

tool_req__docs_common_attr_version - Make version attribute mandatory (currently optional)

2 participants