Conversation
Pin::BaseVariable treats every variable as lexically scoped, giving up once the reading closure's namespace walk finds no match. Ancestor ivar-assignment candidates from get_instance_variable_pins were discarded, since a descendant class is never lexically nested inside the ancestor class that defines it. InstanceVariable now accepts a pin once the walk bottoms out with no match, and only enforces same-file placement when presence (flow-sensitive narrowing) is actually set. Fixes castwide#1261
Compress the two method docstrings this PR added down to the non-obvious why, drop a duplicate inline comment restating the same point, and shorten the top-level-visibility guard comment. No code changes.
apiology
marked this pull request as ready for review
September 6, 2026 20:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: written on behalf of @apiology.
Fixes #1261
Problem: An instance variable assigned only in an ancestor class's method gets no inferred type in the descendant, so every read of it fails at
--level strong.This hits any class hierarchy where a base class sets up state its subclasses read, including when the two live in different files.
Solution:
Pin::InstanceVariableoverridesvisible_in_closure?to accept a candidate when the lexical walk bottoms out at a non-matchingNamespace—ApiMap#get_instance_variable_pinshas already restricted candidates to the reading namespace and its ancestors — and overridesvisible_at?so the same-file requirement applies only whenpresence(flow-sensitive narrowing) is set.🤖 Generated with Claude Code