Conversation
Pin::BaseVariable treats every variable as lexically scoped, giving up once the reading closure's namespace walk finds no match. Ancestor ivar-assignment candidates from get_instance_variable_pins were discarded, since a descendant class is never lexically nested inside the ancestor class that defines it. InstanceVariable now accepts a pin once the walk bottoms out with no match, and only enforces same-file placement when presence (flow-sensitive narrowing) is actually set. Fixes castwide#1261
apiology
added a commit
that referenced
this pull request
Aug 22, 2026
Compress the two method docstrings this PR added down to the non-obvious why, drop a duplicate inline comment restating the same point, and shorten the top-level-visibility guard comment. No code changes.
Owner
Author
|
Claude: Reopened upstream as castwide#1345, from the same branch. Closing this copy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was written by Claude Code on behalf of @apiology.
Fixes castwide#1261
Pin::BaseVariable#visible_at?/#visible_in_closure?treats every variable as lexically scoped, walking the closure nesting of the reading site and giving up once it reaches an enclosingNamespacepin with no matching binder namespace.ApiMap#get_instance_variable_pinsalready walks the superclass chain to gather ivar-assignment candidates from ancestor classes, butvar_at_locationdiscarded those candidates anyway, because a descendant class's namespace is never lexically nested inside its ancestor's.Pin::InstanceVariablenow overridesvisible_in_closure?to accept a pin once the lexical walk bottoms out at aNamespacewith no match, sinceget_instance_variable_pinshas already restricted candidates to the reading namespace and its ancestors. It also overridesvisible_at?so the same-file requirement only applies whenpresence(flow-sensitive narrowing) is actually set - a plain, unnarrowed ivar assignment can legitimately live in a different file than the read (e.g. an ancestor class defined in its own file).Example that now typechecks cleanly at
--level strong:Full spec suite: 1627 examples, 0 failures.