Skip to content

refactor: replace kontocheck with fintech.iban - #457

Merged
barredterra merged 3 commits into
version-16-hotfixfrom
refactor/replace-kontocheck
Oct 6, 2026
Merged

barredterra merged 3 commits into
version-16-hotfixfrom
refactor/replace-kontocheck

Conversation

@barredterra

Copy link
Copy Markdown
Member

The kontocheck project will be discontinued, so its bank data will no longer be updated. Since v7.9.0, fintech ships its own bank data in fintech.iban. The pinned fintech==7.9.1 already includes it.

Changes

  • Remove the kontocheck dependency.
  • Use fintech.iban for IBAN validation, bank name and BIC lookup (Bank Account, SEPA Payment Order, create_bank). fintech.iban needs fintech.register(), so each call site calls register_fintech() first. This works without a license key (demo mode).
  • Bank Account: the BIC check now also runs for Austrian and Swiss IBANs, because fintech has the bank codes for DE, AT and CH.

Notes

  • fintech's check_iban also rejects German IBANs with an unknown bank code.
  • Existing Austrian or Swiss Bank Accounts linked to a Bank with a different BIC now fail validation on the next save. The error message names the correct BIC.

kontocheck will no longer receive bank data updates. fintech ships its
own bank data since v7.9.0.
@barredterra

Copy link
Copy Markdown
Member Author

@Mergifyio backport version-15-hotfix

@mergify

mergify Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

backport version-15-hotfix

✅ Backports have been created

Details

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Replaces IBAN validation library with a different one.

The PR appears safe to merge, with the previous test gap addressed and no new blocking issues found.

What we checked:

  • Matching accounts satisfy required fields: The tests supply both required fields. ERPNext requires a company and accounting account only when is_company_account is enabled; it defaults to disabled here.

Reviews (2) · Last reviewed commit: "refactor(test_bank_account): enhance IBA..."

Comment thread banking/overrides/test_bank_account.py Outdated
@barredterra
barredterra merged commit b6e54e9 into version-16-hotfix Oct 6, 2026
4 checks passed
@barredterra
barredterra deleted the refactor/replace-kontocheck branch October 6, 2026 22:07
barredterra added a commit that referenced this pull request Oct 6, 2026
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@barredterra

Copy link
Copy Markdown
Member Author

🎉 This PR is included in version 16.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant