fix(SEPA Payment Order): keep stored BIC and sync bank name (backport #459)

[mergify]

Follow-up to #455 and #457.

BIC

EUR payments within the EEA are IBAN-only, so #455 cleared the BIC on save. That lost the BIC for good. If the debtor IBAN, the payment IBAN or the currency changed later, the payment needed a BIC but had none.

Now the stored BIC stays. Only the XML leaves it out for EEA-to-EEA EUR payments. A BIC of another branch still cannot break the order.

Bank name

The read-only bank name was only set when empty, so it went stale after an IBAN change. Now it is derived on every save from the IBAN (DE, AT, CH) or else from the BIC (European BICs). If neither is known, it is cleared.

Tests

• test_eea_payment_has_no_bic checks that the stored BIC stays and the XML still renders with a mismatching BIC.
• New test_bank_name_follows_iban covers IBAN lookup, clearing, and BIC fallback.

  ---

  This is an automatic backport of pull request fix(SEPA Payment Order): keep stored BIC and sync bank name #459 done by Mergify.

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Changes how bank names and BICs are handled in SEPA payments.

This backport appears safe to merge.

What we checked:

• Stored BIC bypasses transfer rules: Submission, download, and bank transmission all call to_sepa_credit_transfer, which excludes the stored BIC for EEA-to-EEA EUR payments.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Payment row keeps stored BIC] --> B{Both IBANs in EEA and currency EUR?}
  B -->|Yes| C[Build recipient account without stored BIC]
  B -->|No| D[Build recipient account with stored BIC]
  C --> E[Render or send transfer]
  D --> E

Loading

_{Reviews (1) · Last reviewed commit: "fix(SEPA Payment Order): keep stored BIC..."}

[barredterra]

🎉 This PR is included in version 15.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀