Skip to content

test: fixes e2e tests in deploy-web #3399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stalniy merged 1 commit into from
Jul 9, 2026
+10 −8
Merged

test: fixes e2e tests in deploy-web #3399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions apps/deploy-web/tests/ui/configure-deployment-flow.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ test.describe("Configure deployment — request quotes flow", () => {
await configure.requestQuotes();

// the created deployment's dseq is mirrored into the route segment
await page.waitForURL(/\/new-deployment\/configure\/\d+/, { timeout: 90_000 });
await page.waitForURL(/\/new-deployment\/configure\/\d+/, { timeout: 15_000 });

await expect(configure.lockBannerText().first()).toBeVisible({ timeout: 30_000 });
await expect(configure.lockBannerText().first()).toBeVisible();
await expect(configure.cpuInput()).toBeDisabled();
await expect(configure.dockerImageInput()).toBeEnabled();

Expand All @@ -37,10 +37,9 @@ test.describe("Configure deployment — request quotes flow", () => {

await test.step("cancel and edit closes the deployment and unlocks the pane", async () => {
await configure.cancelAndEdit();
await expect(configure.cancellingButton()).toBeVisible();

// closing drops the dseq from the route
await page.waitForURL(url => !/\/new-deployment\/configure\/\d+/.test(url.pathname), { timeout: 90_000 });

await expect(configure.cancellingButton()).not.toBeVisible({ timeout: 15_000 });
await expect(configure.lockBannerText()).toHaveCount(0);
await expect(configure.cpuInput()).toBeEnabled();
await expect(configure.requestQuotesButton()).toBeVisible();
Expand Down
5 changes: 2 additions & 3 deletions apps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,8 @@ test.describe("Onboarding picker — unlocking the gated LLM template via Add Cr
await expect(addCreditsSheet.getDialog()).toBeHidden({ timeout: 30_000 });
});

await test.step("the LLM template CTA unlocks to 'Deploy now'", async () => {
await expect(onboardingPickerPage.getLlmChatbotCta()).toHaveText(/deploy now/i, { timeout: 30_000 });
await expect(onboardingPickerPage.getLlmChatbotCta()).toBeEnabled();
await test.step("the LLM template starts deploying", async () => {
await expect(page.getByText("Deploying")).toBeVisible();
});
Comment thread
stalniy marked this conversation as resolved.
});
});
4 changes: 4 additions & 0 deletions apps/deploy-web/tests/ui/pages/ConfigureDeploymentPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ export class ConfigureDeploymentPage {
return this.page.getByRole("button", { name: "Request quotes" });
}

cancellingButton() {
return this.page.getByRole("button", { name: "Cancelling", exact: true });
}

/** The lock banner copy shown in each spec pane while quotes are active. */
lockBannerText() {
return this.page.getByText("Changing a locked setting needs new quotes.");
Expand Down