test: fixes e2e tests in deploy-web#3399
Conversation
📝 WalkthroughWalkthroughPlaywright UI tests for configure-deployment flow and onboarding trial unlock were updated with tighter timeouts and new assertions on button state instead of URL route changes. A new ChangesE2E Test Assertion and Timing Updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3399 +/- ##
==========================================
- Coverage 71.75% 70.66% -1.09%
==========================================
Files 1149 1059 -90
Lines 28978 26645 -2333
Branches 7106 6654 -452
==========================================
- Hits 20794 18830 -1964
+ Misses 7187 6850 -337
+ Partials 997 965 -32
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.ts`:
- Around line 54-56: The “Deploying” assertion in the onboarding picker test is
too ambiguous and uses the default timeout. Update the `test.step("the LLM
template starts deploying")` check in `onboarding-picker-unlock-trial.spec` to
target a unique locator from `PhasedDeploymentProgress` (for example, the
heading or a more specific text match) so it doesn’t match both the label and
heading, and add an explicit longer timeout consistent with the other async
assertions in this test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3ebec368-b197-4a69-856e-437c0a22ffb4
📒 Files selected for processing (3)
apps/deploy-web/tests/ui/configure-deployment-flow.spec.tsapps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.tsapps/deploy-web/tests/ui/pages/ConfigureDeploymentPage.ts
Why
e2e tests are broken
What
Summary by CodeRabbit