Skip to content

test: fixes e2e tests in deploy-web#3399

Merged
stalniy merged 1 commit into
mainfrom
test/fix-e2e
Jul 9, 2026
Merged

test: fixes e2e tests in deploy-web#3399
stalniy merged 1 commit into
mainfrom
test/fix-e2e

Conversation

@stalniy

@stalniy stalniy commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

e2e tests are broken

What

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability of deployment status updates during quote requests and cancel/edit actions.
    • Fixed the onboarding flow so unlocking the trial now correctly transitions into deployment start.
    • Made deployment progress and cancellation states appear and clear more consistently in the UI.

@stalniy stalniy changed the title Test/fix e2e test: fixes e2e tests in deploy-web Jul 9, 2026
@stalniy stalniy enabled auto-merge July 9, 2026 08:57
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Playwright UI tests for configure-deployment flow and onboarding trial unlock were updated with tighter timeouts and new assertions on button state instead of URL route changes. A new cancellingButton() locator helper was added to ConfigureDeploymentPage.

Changes

E2E Test Assertion and Timing Updates

Layer / File(s) Summary
Cancel/edit flow timing and cancelling button helper
apps/deploy-web/tests/ui/configure-deployment-flow.spec.ts, apps/deploy-web/tests/ui/pages/ConfigureDeploymentPage.ts
Reduces waitForURL timeout to 15s, drops extended lock-banner timeout, and replaces the URL-route-drop wait with new cancellingButton() visible-then-hidden assertions backed by a new page object locator.
Onboarding trial unlock deployment assertion
apps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.ts
Replaces the "Deploy now" CTA enabled assertion with a wait for the "Deploying" UI state after the credits sheet closes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • akash-network/console#3379: Related to ConfigureDeploymentHeader CTA state/label handling that the new cancellingButton() assertions exercise.
  • akash-network/console#3392: Underlying cancelAndEdit dseq-clearing behavior change that the updated cancel/edit test timing verifies.
  • akash-network/console#3397: Fixes to onboarding managed-wallet creation flow that the updated "Deploying" assertion relates to.

Suggested reviewers: ygrishajev

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/fix-e2e

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.66%. Comparing base (993e7c1) to head (4d2a4ee).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3399      +/-   ##
==========================================
- Coverage   71.75%   70.66%   -1.09%     
==========================================
  Files        1149     1059      -90     
  Lines       28978    26645    -2333     
  Branches     7106     6654     -452     
==========================================
- Hits        20794    18830    -1964     
+ Misses       7187     6850     -337     
+ Partials      997      965      -32     
Flag Coverage Δ *Carryforward flag
api 85.60% <ø> (ø) Carriedforward from 993e7c1
deploy-web 60.00% <ø> (ø)
log-collector ?
notifications 91.44% <ø> (ø) Carriedforward from 993e7c1
provider-console 81.38% <ø> (ø) Carriedforward from 993e7c1
provider-inventory ?
provider-proxy 86.42% <ø> (ø) Carriedforward from 993e7c1
tx-signer ?

*This pull request uses carry forward flags. Click here to find out more.
see 90 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.ts`:
- Around line 54-56: The “Deploying” assertion in the onboarding picker test is
too ambiguous and uses the default timeout. Update the `test.step("the LLM
template starts deploying")` check in `onboarding-picker-unlock-trial.spec` to
target a unique locator from `PhasedDeploymentProgress` (for example, the
heading or a more specific text match) so it doesn’t match both the label and
heading, and add an explicit longer timeout consistent with the other async
assertions in this test.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3ebec368-b197-4a69-856e-437c0a22ffb4

📥 Commits

Reviewing files that changed from the base of the PR and between 993e7c1 and 4d2a4ee.

📒 Files selected for processing (3)
  • apps/deploy-web/tests/ui/configure-deployment-flow.spec.ts
  • apps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.ts
  • apps/deploy-web/tests/ui/pages/ConfigureDeploymentPage.ts

Comment thread apps/deploy-web/tests/ui/onboarding-picker-unlock-trial.spec.ts

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: all changes are related to tests.

@stalniy stalniy added this pull request to the merge queue Jul 9, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2026
@stalniy stalniy added this pull request to the merge queue Jul 9, 2026
Merged via the queue into main with commit 886fe7b Jul 9, 2026
57 checks passed
@stalniy stalniy deleted the test/fix-e2e branch July 9, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant