Skip to content

SMB2Client: Update the security data during authentication #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErmolaevYura wants to merge 2 commits into
base: master
Choose a base branch
from
Open

SMB2Client: Update the security data during authentication #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cdb0e6
SMB2Client: Update the security data during authentication
ErmolaevYura Aug 17, 2026
00bfc30
NTLMAuthenticationClient: Ignore null challengeMessageBytes
ErmolaevYura Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions SMBLibrary/Client/Authentication/NTLMAuthenticationClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ protected virtual byte[] GetAuthenticateMessage(byte[] securityBlob)
challengeMessageBytes = securityBlob;
}

// When NegState is AcceptCompleted or Reject, the SPNEGO token may not contain a Response Token
if (challengeMessageBytes == null)
return null;

byte[] authenticateMessageBytes = NTLMAuthenticationHelper.GetAuthenticateMessage(m_negotiateMessageBytes, challengeMessageBytes, m_domainName, m_userName, m_password, m_spn, m_authenticationMethod, out m_sessionKey);
if (useGSSAPI && authenticateMessageBytes != null)
{
Expand Down
10 changes: 10 additions & 0 deletions SMBLibrary/Client/SMB2Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,16 @@ public NTStatus Login(IAuthenticationClient authenticationClient)
if (m_isLoggedIn)
{
m_sessionID = response.Header.SessionID;
if (finalSessionSetupResponse.SecurityBuffer != null && finalSessionSetupResponse.SecurityBuffer.Length > 0)
{
// Some authentication mechanisms (e.g. Kerberos) embed acceptor-provider
// context data (such as an AP-REP subkey) in the final, successful
// SESSION_SETUP response. Give the authentication client a chance to
// process it before deriving the session key, since it may override
// the key negotiated so far.
authenticationClient.InitializeSecurityContext(finalSessionSetupResponse.SecurityBuffer);
}

m_sessionKey = authenticationClient.GetSessionKey();
m_authenticationClient = authenticationClient;
SessionFlags sessionFlags = finalSessionSetupResponse.SessionFlags;
Expand Down