SMB2Client: Update the security data during authentication - #360
Open
ErmolaevYura wants to merge 2 commits into
Open
SMB2Client: Update the security data during authentication#360ErmolaevYura wants to merge 2 commits into
ErmolaevYura wants to merge 2 commits into
Conversation
Owner
|
Thanks. Will look into it when time permits. |
Owner
|
Thanks again, I'm seeing two changes here:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello TalAloni,
Thank you for working on this amazing library!
I found an issue related to implementing Kerberos signing and encryption, and I would like to suggest a small fix for it. I would be glad if I could help improve this library.
According to RFC 4120 (The Kerberos Network Authentication Service (V5)), Section 3.2.6 (Using the Encryption Key), page 34:
One way that an application may choose to negotiate a key to be used for subsequent integrity and privacy protection is for the client to propose a key in the subkey field of the authenticator. The server can then choose a key using the key proposed by the client as input, returning the new subkey in the subkey field of the application reply. This key could then be used for subsequent communication.Therefore, the SMB2Client should send the security data back to the authenticator so that it can correctly generate a new session key.