Clarify the Agreement id help text - #129
Merged
Merged
Conversation
The old text ("the agreement id used for the payment window") did not say what
happens when the field is left empty, making the field look vestigial. The new
text states the fallback - empty means the Quickpay account's default Payment
Window agreement - and that only accounts with several agreements need to set
it. Updated in all 16 locales.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #129 +/- ##
=========================================
Coverage 93.86% 93.86%
Complexity 205 205
=========================================
Files 25 25
Lines 766 766
=========================================
Hits 719 719
Misses 47 47 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Agreement idfield is alive and consumed on every payment-link creation (payum-quickpay'sCreatePaymentLinkActionsends it as the link'sagreement_id), but its help text — "the agreement id used for the payment window" — didn't say what happens when it is left empty, which made the field look vestigial.The new text spells out the behavior: leave it empty to use the Quickpay account's default Payment Window agreement; set it only when the account has several agreements and the window should run on a specific one. Updated in all 16 locales (en source; da, sv, no, fi, de, fr, es, it, nl, pl, pt, cs, hu, ro, uk).