fix(providers): preserve Codex SSE error details - #268
Open
fancyboi999 wants to merge 1 commit into
Open
Conversation
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
type,code, andmessagedetails from Codexerrorandresponse.failedSSE events.Type
Verification
uv run pytest tests/test_openai_codex_provider.py tests/test_error_classification.py tests/test_provider_fallback_chain.py -q: 53 passed.uv run --all-extras pytest -q --deselect tests/test_cli_theme.py::test_bold_accent_renders_styled_not_bare: 5158 passed, 30 skipped, 14 deselected, 2 warnings.uv run --extra dev ruff check raven/providers/openai_codex_provider.py tests/test_openai_codex_provider.py: passed.uv run --extra dev ruff format --check raven/providers/openai_codex_provider.py tests/test_openai_codex_provider.py: passed.uv run pre-commit run --files raven/providers/openai_codex_provider.py tests/test_openai_codex_provider.py: passed.Live OAuth call through
OpenAICodexProvider.chat_with_retry()using an account-advertised Codex model returnedfinish_reason=stopand the expectedRAVEN_E2E_OKresponse.make cireaches one pre-existingtests/test_cli_theme.py::test_bold_accent_renders_styled_not_barefailure reproduced unchanged on a cleanorigin/mainworktree. The remaining TUI tests and builds passed when run separately.Relevant tests pass locally
Relevant lint / type checks pass locally
User-facing docs or screenshots are updated when needed
No user-facing documentation describes this internal error representation, so no documentation or screenshots were changed.
Risk
Error output changes from a fixed generic string to bounded structured fields for Codex SSE failures.
Unrelated and malformed failures retain non-retryable or generic behavior, and the change can be rolled back by reverting this PR.
Security impact considered
Backward compatibility considered
Rollback path is clear for risky changes
Related Issues
Fixes #234