Skip to content

fix(providers): resolve Codex models from account catalog - #270

Open
fancyboi999 wants to merge 1 commit into
EverMind-AI:mainfrom
fancyboi999:fix/codex_model_catalog
Open

fix(providers): resolve Codex models from account catalog#270
fancyboi999 wants to merge 1 commit into
EverMind-AI:mainfrom
fancyboi999:fix/codex_model_catalog

Conversation

@fancyboi999

Copy link
Copy Markdown

Summary

  • Add one account-scoped Codex model catalog adapter shared by credential probing and runtime model resolution.
  • Replace the two stale hard-coded Codex defaults with openai-codex/auto, while preserving explicitly configured models.
  • Filter picker-visible models, respect catalog priority, fail clearly on empty or malformed responses, and use conditional account headers.
  • Cache automatic resolution per account for five minutes so account switches and catalog changes do not reuse an indefinitely stale model.
  • Route provider test openai-codex through the Codex catalog and show OAuth-specific remediation instead of API-key instructions.

Type

  • Fix
  • Feature
  • Docs
  • CI / tooling
  • Refactor
  • Other

Verification

  • Relevant tests pass locally

  • Relevant lint / type checks pass locally

  • User-facing docs or screenshots are updated when needed

  • uv run --all-extras pytest -q --deselect tests/test_cli_theme.py::test_bold_accent_renders_styled_not_bare

    • 5167 passed, 30 skipped, 14 deselected, 2 warnings
  • npm test --prefix ui-tui

    • 83 files and 953 tests passed
  • npm run build --prefix ui-tui

    • passed
  • npm run build --prefix bridge

    • passed
  • uv run raven provider test openai-codex

    • 4 visible account models returned
  • Real Raven provider E2E using the openai-codex/auto default:

    • resolved an account-advertised model
    • finish_reason=stop
    • exact response RAVEN_AUTO_E2E_FINAL_OK
  • make ci

    • reaches the full Python suite but retains one pre-existing theme failure:
      tests/test_cli_theme.py::test_bold_accent_renders_styled_not_bare
    • the same failure reproduces in the separate fix(providers): preserve Codex SSE error details #268 worktree, and this PR has no diff in the theme or dependency files

Risk

  • Security impact considered
  • Backward compatibility considered
  • Rollback path is clear for risky changes

OAuth tokens and account ids are never logged. Catalog failures do not fall back to stale model ids, and explicit model selections bypass catalog resolution.

Related Issues

Fixes #212
Fixes #269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(openai_codex): resolve defaults from the account model catalog openai_codex provider test expects API key despite valid OAuth credentials

1 participant