Make APPAR_TEMP and DISCOIS variables available when calc_human_stress_indices is FAST

[olyson]

Description of changes

Make APPAR_TEMP and DISCOIS variables available when calc_human_stress_indices is FAST.
These variables do not depend on the more expensive wet bulb calculation (calc_human_stress_indices=ALL).
Accomplish this by moving these variables out from within this if block within HumanIndexMod.F90:

if ( all_human_stress_indices )then

Specific notes

Contributors other than yourself, if any:

• J. Buzan

CTSM issues resolved or otherwise addressed, if any:
None

Any user interface changes (namelist or namelist defaults changes)?
No

Testing planned or performed, if any:

• ./run_sys_tests -c ctsm5.4.044 --skip-generate -s clm_short --baseline-root /glade/campaign/cgd/tss/ctsm_baselines/ --account P93300041
  Results are bfb except for field list differences as expected:

0708-082809de_gnu: 2 tests
    FAIL ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL ERS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)


0708-082809de_int: 5 tests
    FAIL ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL ERP_D_P64x2_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default--clm-matrixcnOn_ignore_warnings BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL ERS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL SMS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)
    FAIL SMS_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_intel.clm-default--clm-matrixcnOn BASELINE ctsm5.4.044: FIELDLIST field lists differ (otherwise bit-for-bit)

Requirements before merge:

• I have followed the CTSM contribution guidelines.
• The code in this PR branch builds with no errors.
• The code in this PR branch runs with no errors. Briefly describe tested configuration(s): clm_short
• This either (a) does not change answers, (b) it only changes answers at roundoff level, or (c) I have performed a scientific evaluation of the answer changes. Which?: (a)
• I have reviewed relevant parts of the CLM documentation Tech Note or User's Guide to determine if anything needs to be changed or added. If it does, describe: NA
• This PR either (a) does not create a need to update the documentation or (b) includes required documentation updates (see guidelines for contributing documentation). Which?: (a)

[olyson]

This was supposed to go on b4b-dev but somehow I've based this on main. Suggestions on how to fix this?

[olyson]

This was supposed to go on b4b-dev but somehow I've based this on main. Suggestions on how to fix this?

Ok, I've fixed this.

[olyson]

aux_clm failures on Derecho (other than expected field list differences and EXPECTED FAILURES):

FAIL LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac NLCOMP

I don't see this listed as expected. The baseline namelists nuopc.runseq and nuopc.runconfig are missing. And there are items present in the baseline drv_flds_in that aren't in my version. Similarly in drv_in and lnd_in.
The baseline TestStatus for NLCOMP says (used lilac namelists), but mine doesn't say that I don't see how this has anything to do with my changes however.
So I resubmitted this and it passed (now the TestStatus for NLCOMP says used lilac namelists).

aux_clm failures on Izumi (other than expected field list differences and EXPECTED FAILURES):

FAIL ERP_D_Ld5_P48x1.f10_f10_mg37.I2000Clm50Sp.izumi_nag.clm-o3lombardozzi2015 RUN time=381
FAIL ERS_D_Ld10.5x5_amazon_r05.I2000Clm60SpMizGs.izumi_nag.mizuroute-default NLCOMP
FAIL SMS_D_Ld5.5x5_amazon_rHDMA.I2000Clm60SpMizGs.izumi_nag.mizuroute-default NLCOMP

I think the mizuroute NLCOMP failures should be expected since they have the test case name in the namelist file.
E.g., the baseline for mizuRoute.control has:

<case_name>                  ERS_D_Ld10.5x5_amazon_r05.I2000Clm60SpMizGs.izumi_nag.mizuroute-default.GC.0709-162952iz_nag

and my branch mizuRoute.control has:

<case_name>                  ERS_D_Ld10.5x5_amazon_r05.I2000Clm60SpMizGs.izumi_nag.mizuroute-default.C.0715-115859iz_nag

The lombardozzi run failed with this error in the cesm log at the end of the case2run:

Warning: Floating underflow occurred
Warning: Floating underflow occurred
[mpiexec@i029.cgd.ucar.edu] HYDT_bscd_pbs_wait_for_completion (tools/bootstrap/external/pbs_wait.c:66): tm_poll(obit_event) failed with TM error 17002
[mpiexec@i029.cgd.ucar.edu] HYDT_bsci_wait_for_completion (tools/bootstrap/src/bsci_wait.c:23): launcher returned error waiting for completion
[mpiexec@i029.cgd.ucar.edu] HYD_pmci_wait_for_completion (pm/pmiserv/pmiserv_pmci.c:218): launcher returned error waiting for completion
[mpiexec@i029.cgd.ucar.edu] main (ui/mpich/mpiexec.c:340): process manager error waiting for completion

The mediator log show successful completion:

  SUCCESSFUL TERMINATION OF CMEPS
: ===============  # simulated years / cmp-day =       33.502  ===============

I reran this test and it passed.

So, in summary, aux_clm testing on Derecho and Izumi passed (eventually) and I will merge this to b4b-dev tomorrow.

[slevis-lmwg]

@ekluzek
I'm posting the exact field-list diffs from Keith's aux_clm tests_0715-115059de to help with the upcoming b4b-dev merge.

Most of the fields are either APPAR_TEMP* or DISCOIS*, so I grep those out and then also get these:

grep "Could not find match" */*cprnc.out | grep -v APPAR_TEMP | grep -v DISCOIS

ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable ZSOI in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable DZSOI in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable WATSAT in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable SUCSAT in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable BSW in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable HKSAT in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable ZLAKE in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable DZLAKE in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable PCT_SAND in file1
ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu/ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs.C.0715-115059de_gnu.clm2.h0a.1850-01-04-00000.nc.base.cprnc.out: Could not find match for file2 variable PCT_CLAY in file1