Comment out fields failing in #3661 so test may catch future problems - #4136
Merged
Conversation
Contributor
Author
|
@billsacks I requested your review since you got involved in #3661. I think the review should take 5 minutes :-) |
billsacks
requested changes
Jul 22, 2026
billsacks
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! A couple of suggestions below.
This comment was marked as outdated.
This comment was marked as outdated.
10 tasks
Contributor
|
Here's the list of 35 diagnostic fields that were commented out. +! call hist_addfld1d (fname='LEAFCN_STORAGE', units='gC/gN', &
+! call hist_addfld1d (fname='GAMMA', units='non', &
+! call hist_addfld1d (fname='GAMMAL', units='non', &
+! call hist_addfld1d (fname='GAMMAT', units='non', &
+! call hist_addfld1d (fname='GAMMAP', units='non', &
+! call hist_addfld1d (fname='GAMMAA', units='non', &
+! call hist_addfld1d (fname='GAMMAS', units='non', &
+! call hist_addfld1d (fname='GAMMAC', units='non', &
+! call hist_addfld1d (fname='EOPT', units='non', &
+! call hist_addfld1d (fname='TOPT', units='non', &
+! call hist_addfld1d (fname='ALPHA', units='non', &
+! call hist_addfld1d (fname='currentPatch', units='non', &
+! call hist_addfld1d (fname='PAR_sun', units='umol/m2/s', &
+! call hist_addfld1d (fname='PAR24_sun', units='umol/m2/s', &
+! call hist_addfld1d (fname='PAR240_sun', units='umol/m2/s', &
+! call hist_addfld1d (fname='PAR_shade', units='umol/m2/s', &
+! call hist_addfld1d (fname='PAR24_shade', units='umol/m2/s', &
+! call hist_addfld1d (fname='PAR240_shade', units='umol/m2/s', &
+! call hist_addfld2d (fname='RRESIS', units='proportion', type2d='levgrnd', &
+! call hist_addfld1d (fname='RAH1', units='s/m', &
+! call hist_addfld1d (fname='RAH2', units='s/m', &
+! call hist_addfld1d (fname='RAW1', units='s/m', &
+! call hist_addfld1d (fname='RAW2', units='s/m', &
+! call hist_addfld1d (fname='USTAR', units='m/s', &
+! call hist_addfld1d (fname='UM', units='m/s', &
+! call hist_addfld1d (fname='UAF', units='m/s', &
+! call hist_addfld1d (fname='TAF', units='K', &
+! call hist_addfld1d (fname='QAF', units='kg/kg', &
+! call hist_addfld1d (fname='VPD', units='kPa', &
+! call hist_addfld2d (fname='KROOT', units='1/s', type2d='levsoi', &
+! call hist_addfld2d (fname='KSOIL', units='1/s', type2d='levsoi', &
+! call hist_addfld2d (fname='SNO_TK', units='W/m-K', type2d='levsno', &
+! call hist_addfld2d (fname='EFF_POROSITY', units='proportion', type2d='levgrnd', &
+! call hist_addfld1d ( fname=this%info%fname('RHAF'), &
+! call hist_addfld2d ( fname=this%info%fname('SNO_BW'), & |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Commented out fields listed in #3661 (comment) to allow all_outputs test to catch future problems.
Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Contributes to #3661
Testing planned or performed, if any:
ERP_P36x2_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default--clm-all_outputsonly field lists differ after commenting out the previously failing fieldsERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputswhich is the current all_outputs test./run_sys_tests -s aux_clm -c ctsm5.4.047 --skip-generateResubmitting
ERP_D_P64x2_Ld3.f10_f10_mg37.I2000Clm50BgcCru.derecho_intel.clm-noFUN_flexCN--clm-matrixcnOn_ignore_warningsuntil it passes (known issue)Requirements before merge: