Skip to content

Comment out fields failing in #3661 so test may catch future problems - #4136

Merged
slevis-lmwg merged 5 commits into
ESCOMP:b4b-devfrom
slevis-lmwg:all_outputs_testpatch
Jul 27, 2026
Merged

Comment out fields failing in #3661 so test may catch future problems#4136
slevis-lmwg merged 5 commits into
ESCOMP:b4b-devfrom
slevis-lmwg:all_outputs_testpatch

Conversation

@slevis-lmwg

@slevis-lmwg slevis-lmwg commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Commented out fields listed in #3661 (comment) to allow all_outputs test to catch future problems.

Specific notes

Contributors other than yourself, if any:

CTSM issues resolved or otherwise addressed, if any:
Contributes to #3661

Testing planned or performed, if any:

  • ERP_P36x2_D_Ld3.f10_f10_mg37.I1850Clm50BgcCrop.derecho_gnu.clm-default--clm-all_outputs only field lists differ after commenting out the previously failing fields
  • Repeating with ERP_P64x2_D_Ld3.f10_f10_mt232.IHistClm60BgcCropCrujra.derecho_gnu.clm-default--clm-all_outputs which is the current all_outputs test
  • derecho: ./run_sys_tests -s aux_clm -c ctsm5.4.047 --skip-generate
    Resubmitting ERP_D_P64x2_Ld3.f10_f10_mg37.I2000Clm50BgcCru.derecho_intel.clm-noFUN_flexCN--clm-matrixcnOn_ignore_warnings until it passes (known issue)
  • aux_clm on izumi
  • The last commit in this PR adds more comment lines, so I'm taking the risk of not repeating the above testing

Requirements before merge:

  • The code in this PR branch builds with no errors.
  • The code in this PR branch runs with no errors. Briefly describe tested configuration(s): See above for testing performed.
  • This does not change answers
  • This PR does not create a need to update the documentation

@slevis-lmwg slevis-lmwg self-assigned this Jul 21, 2026
@slevis-lmwg slevis-lmwg added b4b bit-for-bit testing additions or changes to tests labels Jul 21, 2026
@slevis-lmwg
slevis-lmwg requested a review from billsacks July 21, 2026 23:14
@slevis-lmwg

Copy link
Copy Markdown
Contributor Author

@billsacks I requested your review since you got involved in #3661. I think the review should take 5 minutes :-)
Let me know if you prefer that I ask a different reviewer.

@billsacks billsacks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! A couple of suggestions below.

Comment thread cime_config/testdefs/ExpectedTestFails.xml Outdated
Comment thread src/biogeochem/NutrientCompetitionFlexibleCNMod.F90

@billsacks billsacks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks a lot!

@slevis-lmwg

This comment was marked as outdated.

@slevis-lmwg slevis-lmwg moved this from In Progress to Stalled in LMWG: Sprint Planning Board Jul 24, 2026
@slevis-lmwg
slevis-lmwg merged commit cf5b87b into ESCOMP:b4b-dev Jul 27, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Stalled to Done in LMWG: Sprint Planning Board Jul 27, 2026
@slevis-lmwg
slevis-lmwg deleted the all_outputs_testpatch branch July 27, 2026 16:10
@ekluzek ekluzek mentioned this pull request Jul 27, 2026
10 tasks
@ekluzek

ekluzek commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Here's the list of 35 diagnostic fields that were commented out.

+!   call hist_addfld1d (fname='LEAFCN_STORAGE', units='gC/gN', &
+!      call hist_addfld1d (fname='GAMMA', units='non',  &
+!      call hist_addfld1d (fname='GAMMAL', units='non',  &
+!      call hist_addfld1d (fname='GAMMAT', units='non',  &
+!      call hist_addfld1d (fname='GAMMAP', units='non',  &
+!      call hist_addfld1d (fname='GAMMAA', units='non',  &
+!      call hist_addfld1d (fname='GAMMAS', units='non',  &
+!      call hist_addfld1d (fname='GAMMAC', units='non',  &
+!      call hist_addfld1d (fname='EOPT', units='non',  &
+!      call hist_addfld1d (fname='TOPT', units='non',  &
+!      call hist_addfld1d (fname='ALPHA', units='non',  &
+!      call hist_addfld1d (fname='currentPatch', units='non',  &
+!      call hist_addfld1d (fname='PAR_sun', units='umol/m2/s', &
+!      call hist_addfld1d (fname='PAR24_sun', units='umol/m2/s', &
+!      call hist_addfld1d (fname='PAR240_sun', units='umol/m2/s', &
+!      call hist_addfld1d (fname='PAR_shade', units='umol/m2/s', &
+!      call hist_addfld1d (fname='PAR24_shade', units='umol/m2/s', &
+!      call hist_addfld1d (fname='PAR240_shade', units='umol/m2/s', &
+!      call hist_addfld2d (fname='RRESIS', units='proportion', type2d='levgrnd', &
+!      call hist_addfld1d (fname='RAH1', units='s/m', &
+!      call hist_addfld1d (fname='RAH2', units='s/m', &
+!      call hist_addfld1d (fname='RAW1', units='s/m', &
+!      call hist_addfld1d (fname='RAW2', units='s/m', &
+!      call hist_addfld1d (fname='USTAR', units='m/s', &
+!      call hist_addfld1d (fname='UM', units='m/s', &
+!      call hist_addfld1d (fname='UAF', units='m/s', &
+!      call hist_addfld1d (fname='TAF', units='K', &
+!      call hist_addfld1d (fname='QAF', units='kg/kg', &
+!      call hist_addfld1d (fname='VPD', units='kPa', &
+!   call hist_addfld2d (fname='KROOT', units='1/s', type2d='levsoi', &
+!   call hist_addfld2d (fname='KSOIL', units='1/s', type2d='levsoi', &
+!   call hist_addfld2d (fname='SNO_TK', units='W/m-K', type2d='levsno', &
+!      call hist_addfld2d (fname='EFF_POROSITY', units='proportion', type2d='levgrnd', &
+!   call hist_addfld1d ( fname=this%info%fname('RHAF'), &
+!   call hist_addfld2d ( fname=this%info%fname('SNO_BW'), &

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b4b bit-for-bit testing additions or changes to tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants